Skip to content

Fix QueryPreAttentionNormalisation docstring to describe query scaling #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PratikDhanave wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix QueryPreAttentionNormalisation docstring to describe query scaling #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gemma/gm/nn/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def make_attention_layers_types(


class QueryPreAttentionNormalisation(enum.Enum):
"""Initialization strategy."""
"""Query pre-attention scaling strategy."""

# Whether to scale the query by 1/sqrt(head_dim)
BY_ONE_OVER_SQRT_HEAD_DIM = enum.auto()
Expand Down
2 changes: 1 addition & 1 deletion gemma/gm/nn/gemma3n/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def create_kv_cache_sharing_patterns( # pylint: disable=invalid-name


class QueryPreAttentionNormalisation(enum.Enum):
"""Initialization strategy."""
"""Query pre-attention scaling strategy."""

# Apply no scaling.
NONE = enum.auto()
Expand Down