Fix QueryPreAttentionNormalisation docstring to describe query scaling - #760
Open
PratikDhanave wants to merge 1 commit into
Open
Conversation
The enum's docstring read 'Initialization strategy.', but every member (BY_ONE_OVER_SQRT_HEAD_DIM, BY_EMBED_DIM_DIV_NUM_HEADS, ...) selects how the query is scaled before attention -- unrelated to initialization. The line appears copy-pasted; replace with an accurate description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryPreAttentionNormalisation(ingemma/gm/nn/_config.pyandgemma/gm/nn/gemma3n/_config.py) is documented as"""Initialization strategy.""", but every enum member selects how the query is scaled before attention (BY_ONE_OVER_SQRT_HEAD_DIM,BY_EMBED_DIM_DIV_NUM_HEADS,BY_ONE_OVER_SQRT_EMBED_DIM_DIV_NUM_HEADS,NONE) — nothing to do with initialization. The docstring appears copy-pasted from an unrelated enum. Replace it with"""Query pre-attention scaling strategy.""". Docstring only; no behavior change.