Skip to content

cmd/compile: use one LLVM module finalization guard #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhouguangyuan0718 merged 1 commit into from
Oct 30, 2026
Merged

cmd/compile: use one LLVM module finalization guard #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/cmd/compile/internal/ssa/ssa2llvm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5681,8 +5681,6 @@ func LLVMCompile(f *Func) {

var CurrentModule llvm.Module
var type2lTypes = map[*types.Type]llvm.Type{}
var goObjConfigWritten bool
var goObjImportsWritten bool
var llvmModuleFinalized bool
var currentLLVMDataLowerer *llvmDataLowerer
var goObjCompilerUsedNames map[string]bool
Expand Down Expand Up @@ -5854,8 +5852,6 @@ func InitModule(pkg *types.Pkg) {

CurrentModule = GlobalCtxt.NewModule(pkg.Path)
CurrentModule.SetTarget(goObjTargetTriple())
goObjConfigWritten = false
goObjImportsWritten = false
llvmModuleFinalized = false
currentLLVMDataLowerer = newLLVMDataLowerer(make(map[*obj.LSym]bool))
llvmGoFunctionSymbols = llvmFunctionSymbolIndex{}
Expand Down Expand Up @@ -5944,15 +5940,9 @@ func finalizeLLVMModule() {
if llvmModuleFinalized {
return
}
if !goObjConfigWritten {
addGoObjConfigMetadata(types.LocalPkg)
goObjConfigWritten = true
}
if !goObjImportsWritten {
emitGoObjImportMetadata()
emitGoObjCgoModuleAsm()
goObjImportsWritten = true
}
addGoObjConfigMetadata(types.LocalPkg)
emitGoObjImportMetadata()
emitGoObjCgoModuleAsm()
finalizeLLVMDebugInfo()
emitGoObjCompilerUsed()
llvmModuleFinalized = true
Expand Down
Loading