Repository navigation
cmd/compile: use one LLVM module finalization guard - #352
Merged
Merged
Conversation
zhouguangyuan0718
marked this pull request as ready for review
October 30, 2026 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalizeLLVMModulealready returns after module finalization, but separately tracks whether configuration and imports were emitted. Remove those two redundant flags and keep the existing module-level guard as the single owner of finalization. Metadata emission order and repeated output behavior stay the same.Validation: rebuilding the local toolchain and running focused metadata, definition-relation, deterministic-output and pre-optimization verifier tests. The complete Linux amd64/arm64 CI matrix must pass before merging.