test(ember): Pin embroider packages away from broken releases - #25066
Merged
Merged
Conversation
Embroider published @embroider/vite 1.7.14, @embroider/macros 1.21.2, @embroider/core 4.6.8 and @embroider/compat 4.1.26 with almost no files, which breaks every ember e2e app. Override just those versions so the pins stop applying once fixed releases land.
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
October 5, 2026 17:03
JPeer264
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embroider published new patch versions of vite, macros, core and compat today with almost no files in the tarballs, which broke every ember e2e app, fixed by overriding just those versions back to the previous ones in the test apps.
The overrides are scoped to the broken versions, so they stop applying once a fixed release is out and can be removed then.