Skip to content

test(ember): Pin embroider packages away from broken releases - #25066

Merged
logaretm merged 1 commit into
developfrom
awad/pin-embroider-broken-release
Oct 5, 2026
Merged

logaretm merged 1 commit into
developfrom
awad/pin-embroider-broken-release

Conversation

@logaretm

@logaretm logaretm commented Oct 5, 2026

Copy link
Copy Markdown
Member

Embroider published new patch versions of vite, macros, core and compat today with almost no files in the tarballs, which broke every ember e2e app, fixed by overriding just those versions back to the previous ones in the test apps.

The overrides are scoped to the broken versions, so they stop applying once a fixed release is out and can be removed then.

Embroider published @embroider/vite 1.7.14, @embroider/macros 1.21.2,
@embroider/core 4.6.8 and @embroider/compat 4.1.26 with almost no files,
which breaks every ember e2e app. Override just those versions so the
pins stop applying once fixed releases land.
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.44 kB - -
@sentry/browser - with treeshaking flags 27.59 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.48 kB - -
@sentry/browser (incl. Tracing) 51.32 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.34 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.32 kB - -
@sentry/browser (incl. Tracing, Replay) 90.95 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.93 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.65 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.65 kB - -
@sentry/browser (incl. Feedback) 46.96 kB - -
@sentry/browser (incl. sendFeedback) 34.5 kB - -
@sentry/browser (incl. FeedbackAsync) 39.6 kB - -
@sentry/browser (incl. Metrics) 30.45 kB - -
@sentry/browser (incl. Logs) 30.74 kB - -
@sentry/browser (incl. Metrics & Logs) 31.39 kB - -
@sentry/react 31.28 kB - -
@sentry/react (incl. Tracing) 53.69 kB - -
@sentry/vue 37.41 kB - -
@sentry/vue (incl. Tracing) 54.24 kB - -
@sentry/svelte 29.47 kB - -
@sentry/remix (Remix 3 client bundle) 55.66 kB - -
CDN Bundle 31.13 kB - -
CDN Bundle (incl. Tracing) 51.87 kB - -
CDN Bundle (incl. Logs, Metrics) 33.37 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.81 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.11 kB - -
CDN Bundle (incl. Tracing, Replay) 89.46 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.42 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.64 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.59 kB - -
CDN Bundle - uncompressed 91.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 154.28 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.53 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 160.23 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 228.17 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 274.09 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 280.02 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.79 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.72 kB - -
@sentry/nextjs (client) 56.19 kB - -
@sentry/sveltekit (client) 51.74 kB - -
@sentry/core/server 40.5 kB - -
@sentry/core/browser 13.51 kB - -
@sentry/node 144.64 kB +0.01% +11 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.22 kB - -
@sentry/node - without tracing 93.21 kB +0.02% +13 B 🔺
@sentry/node - without channel injection 122.85 kB +0.01% +6 B 🔺
@sentry/aws-serverless 101.46 kB +0.01% +7 B 🔺
@sentry/cloudflare (withSentry) - minified 208.47 kB - -
@sentry/cloudflare (withSentry) 516.75 kB - -

View base workflow run

@logaretm
logaretm marked this pull request as ready for review October 5, 2026 17:03
@logaretm
logaretm requested review from a team, Lms24, chargome, msonnb and s1gr1d and removed request for a team October 5, 2026 17:03
@logaretm
logaretm merged commit 637aa3d into develop Oct 5, 2026
48 of 49 checks passed
@logaretm
logaretm deleted the awad/pin-embroider-broken-release branch October 5, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants