Skip to content

Commit 637aa3d

Browse files
authored
test(ember): Pin embroider packages away from broken releases (#25066)
Embroider published new patch versions of vite, macros, core and compat today with almost no files in the tarballs, which broke every ember e2e app, fixed by overriding just those versions back to the previous ones in the test apps. The overrides are scoped to the broken versions, so they stop applying once a fixed release is out and can be removed then.
1 parent e741ce8 commit 637aa3d

4 files changed

Lines changed: 26 additions & 0 deletions

File tree

‎dev-packages/e2e-tests/test-applications/ember-classic/package.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,11 @@
8181
"ember": {
8282
"edition": "octane"
8383
},
84+
"pnpm": {
85+
"overrides": {
86+
"@embroider/macros@1.21.2": "1.21.1"
87+
}
88+
},
8489
"volta": {
8590
"extends": "../../package.json"
8691
}

‎dev-packages/e2e-tests/test-applications/ember-embroider/package.json‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@
6666
"ember": {
6767
"edition": "octane"
6868
},
69+
"pnpm": {
70+
"overrides": {
71+
"@embroider/macros@1.21.2": "1.21.1"
72+
}
73+
},
6974
"volta": {
7075
"extends": "../../package.json"
7176
}

‎dev-packages/e2e-tests/test-applications/ember-strict-resolver/package.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,14 @@
4242
"ember": {
4343
"edition": "octane"
4444
},
45+
"pnpm": {
46+
"overrides": {
47+
"@embroider/vite@1.7.14": "1.7.13",
48+
"@embroider/macros@1.21.2": "1.21.1",
49+
"@embroider/core@4.6.8": "4.6.7",
50+
"@embroider/compat@4.1.26": "4.1.25"
51+
}
52+
},
4553
"volta": {
4654
"extends": "../../package.json"
4755
},

‎dev-packages/e2e-tests/test-applications/ember-vite/package.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@
6767
"ember": {
6868
"edition": "octane"
6969
},
70+
"pnpm": {
71+
"overrides": {
72+
"@embroider/vite@1.7.14": "1.7.13",
73+
"@embroider/macros@1.21.2": "1.21.1",
74+
"@embroider/core@4.6.8": "4.6.7",
75+
"@embroider/compat@4.1.26": "4.1.25"
76+
}
77+
},
7078
"volta": {
7179
"extends": "../../package.json"
7280
}

0 commit comments

Comments
 (0)