Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions javascript/sentry-conventions/src/attributes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10308,7 +10308,7 @@ export type HTTP_STATUS_TEXT_TYPE = string;
* Attribute defined in OTEL: Yes
* Visibility: public
*
* @deprecated Use {@link URL_PATH} (url.path) instead - This attribute is being deprecated in favor of url.path and url.query
* @deprecated - This attribute is being deprecated in favor of url.path, url.query and url.fragment. The value holds all three parts at once, so it has no single replacement.
* @example "/test?foo=bar#buzz"
*/
export const HTTP_TARGET = 'http.target';
Expand Down Expand Up @@ -27366,10 +27366,17 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
visibility: 'public',
example: '/test?foo=bar#buzz',
deprecation: {
replacement: 'url.path',
reason: 'This attribute is being deprecated in favor of url.path and url.query',
reason:
'This attribute is being deprecated in favor of url.path, url.query and url.fragment. The value holds all three parts at once, so it has no single replacement.',
},
changelog: [{ version: '0.1.0', prs: [61] }, { version: '0.0.0' }],
changelog: [
{
version: 'next',
description: 'Documented url.path, url.query and url.fragment as the replacements for http.target',
},
{ version: '0.1.0', prs: [61] },
{ version: '0.0.0' },
],
},
'http.url': {
brief: 'The URL of the resource that was fetched.',
Expand Down Expand Up @@ -35859,7 +35866,7 @@ export const ATTRIBUTE_SEARCH_METADATA: Record<string, AttributeSearchMetadata>
deprecationChain: ['http.response.status_text', 'http.status_text'],
},
'http.target': {
canonicalName: 'url.path',
canonicalName: 'http.target',
type: 'string',
brief: 'The pathname and query string of the URL.',
deprecationChain: ['http.target'],
Expand Down
7 changes: 5 additions & 2 deletions model/attributes/http/http__target.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
"example": "/test?foo=bar#buzz",
"deprecation": {
"_status": null,
"replacement": "url.path",
"reason": "This attribute is being deprecated in favor of url.path and url.query"
"reason": "This attribute is being deprecated in favor of url.path, url.query and url.fragment. The value holds all three parts at once, so it has no single replacement."
},
"visibility": "public",
"changelog": [
{
"version": "next",
"description": "Documented url.path, url.query and url.fragment as the replacements for http.target"
},
{
"version": "0.1.0",
"prs": [61]
Expand Down
9 changes: 6 additions & 3 deletions python/src/sentry_conventions/attributes.py
Original file line number Diff line number Diff line change
Expand Up @@ -6242,7 +6242,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
Apply Scrubbing: auto
Defined in OTEL: Yes
Visibility: public
DEPRECATED: Use url.path instead - This attribute is being deprecated in favor of url.path and url.query
DEPRECATED: No replacement at this time - This attribute is being deprecated in favor of url.path, url.query and url.fragment. The value holds all three parts at once, so it has no single replacement.
Example: "/test?foo=bar#buzz"
"""

Expand Down Expand Up @@ -19267,10 +19267,13 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
visibility=Visibility.PUBLIC,
example="/test?foo=bar#buzz",
deprecation=DeprecationInfo(
replacement="url.path",
reason="This attribute is being deprecated in favor of url.path and url.query",
reason="This attribute is being deprecated in favor of url.path, url.query and url.fragment. The value holds all three parts at once, so it has no single replacement."
),
changelog=[
ChangelogEntry(
version="next",
description="Documented url.path, url.query and url.fragment as the replacements for http.target",
),
ChangelogEntry(version="0.1.0", prs=[61]),
ChangelogEntry(version="0.0.0"),
],
Expand Down
Loading