feat(attributes): Name the replacements for the deprecated http.target - #587
Merged
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛Names
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 27, 2026 08:18
489a2a5 to
0669afc
Compare
JPeer264
marked this pull request as ready for review
August 27, 2026 08:54
JPeer264
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
August 27, 2026 08:54
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 27, 2026 09:26
0669afc to
76c17b8
Compare
Lms24
reviewed
Aug 27, 2026
Member
There was a problem hiding this comment.
As discussed, we can just drop the transformation here and make this a hard replacement. With deprecation status null. Since multiple attributes replace this one, no need to add a replacement specifically but we just document it in the deprecation reason.
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 27, 2026 16:21
76c17b8 to
b583c3b
Compare
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 27, 2026 16:30
b583c3b to
93097d6
Compare
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
2 times, most recently
from
August 27, 2026 17:29
a8a8c9a to
efe4939
Compare
http.target into url.path and url.queryhttp.target
Member
Author
|
@Lms24 the transformation is gone 🪄 |
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 28, 2026 11:49
efe4939 to
6aed053
Compare
`http.target` holds the path, the query string and the fragment in one value. v11 of the JavaScript SDK splits it into `url.path`, `url.query` and `url.fragment`. The deprecation stays `_status: null` and drops the `replacement` field, because there is no single replacement. The three replacements are named in the reason instead. No aliases are added on purpose. An alias group is symmetric, so aliasing `http.target` to both `url.path` and `url.query` would declare those two equivalent to each other. Replaced by getsentry/sentry-javascript#23575 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/conv-http-target-transform
branch
from
August 28, 2026 12:12
6aed053 to
f45b845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http.targetcarried the path, the query string and the fragment in one value, so it cannot be renamed onto a single replacement. v11 of the JavaScript SDK splits it intourl.path,url.queryandurl.fragment.Adds thehttp_target_to_url_path_and_querytransformation and setshttp.targetto_status: "transform".No aliases are added on purpose. An alias group is symmetric, so aliasing
http.targetto bothurl.pathandurl.querywould declare those two equivalent to each other. This matches howgen_ai.request.messagesis modelled.Replaced by getsentry/sentry-javascript#23575