Skip to content

feat(attributes): Name the replacements for the deprecated http.target - #587

Merged
JPeer264 merged 1 commit into
jp/conv-url-path-paramsfrom
jp/conv-http-target-transform
Aug 28, 2026
Merged

feat(attributes): Name the replacements for the deprecated http.target#587
JPeer264 merged 1 commit into
jp/conv-url-path-paramsfrom
jp/conv-http-target-transform

Conversation

@JPeer264

@JPeer264 JPeer264 commented Aug 27, 2026

Copy link
Copy Markdown
Member

http.target carried the path, the query string and the fragment in one value, so it cannot be renamed onto a single replacement. v11 of the JavaScript SDK splits it into url.path, url.query and url.fragment.

Adds the http_target_to_url_path_and_query transformation and sets http.target to _status: "transform".

No aliases are added on purpose. An alias group is symmetric, so aliasing http.target to both url.path and url.query would declare those two equivalent to each other. This matches how gen_ai.request.messages is modelled.

Replaced by getsentry/sentry-javascript#23575

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Name the replacements for the deprecated http.target by JPeer264 in #587
  • Add url.path.params.<key> (deprecated) in favor of url.path.parameter.<key> by JPeer264 in #586
  • Add graphql.source (deprecated) in favor of graphql.document by JPeer264 in #584
  • Add legacy Vercel AI span attributes (deprecated) by JPeer264 in #583
  • Add legacy AMQP and Redis span attributes (deprecated) by JPeer264 in #581
  • Add HTTP body size and status text attributes by msonnb in #574
  • Add graphql.processing.type by andreiborza in #572

Other

  • (span-names) Add url.domainrule for http.client spans by Lms24 in #575

Bug Fixes 🐛

Names

  • Add gen_ai.function_id and gen_ai.pipeline.name to agent span name templates by RulaKhaled in #593
  • Add missing gen_ai ops to span name rules by Lms24 in #579
  • Include tool name in gen_ai.execute_tool span names by Lms24 in #580
  • Correct graphql span name examples by andreiborza in #573

Internal Changes 🔧

  • (attributes) Add search alias for segment name by nsdeschenes in #577
  • (search-metadata) Add visibility field by nsdeschenes in #597

🤖 This preview updates automatically when you update the PR.

@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from 489a2a5 to 0669afc Compare August 27, 2026 08:18
@JPeer264
JPeer264 marked this pull request as ready for review August 27, 2026 08:54
@JPeer264
JPeer264 requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners August 27, 2026 08:54
@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from 0669afc to 76c17b8 Compare August 27, 2026 09:26

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we can just drop the transformation here and make this a hard replacement. With deprecation status null. Since multiple attributes replace this one, no need to add a replacement specifically but we just document it in the deprecation reason.

@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from 76c17b8 to b583c3b Compare August 27, 2026 16:21
@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from b583c3b to 93097d6 Compare August 27, 2026 16:30
@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch 2 times, most recently from a8a8c9a to efe4939 Compare August 27, 2026 17:29
@JPeer264 JPeer264 changed the title feat(attributes): Transform http.target into url.path and url.query feat(attributes): Name the replacements for the deprecated http.target Aug 27, 2026
@JPeer264

Copy link
Copy Markdown
Member Author

@Lms24 the transformation is gone 🪄

@JPeer264
JPeer264 requested a review from Lms24 August 27, 2026 17:35

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adjusting!

@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from efe4939 to 6aed053 Compare August 28, 2026 11:49
`http.target` holds the path, the query string and the fragment in one
value. v11 of the JavaScript SDK splits it into `url.path`, `url.query`
and `url.fragment`.

The deprecation stays `_status: null` and drops the `replacement` field,
because there is no single replacement. The three replacements are named
in the reason instead.

No aliases are added on purpose. An alias group is symmetric, so aliasing
`http.target` to both `url.path` and `url.query` would declare those two
equivalent to each other.

Replaced by getsentry/sentry-javascript#23575

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/conv-http-target-transform branch from 6aed053 to f45b845 Compare August 28, 2026 12:12
@JPeer264
JPeer264 merged commit 8ab51a2 into main Aug 28, 2026
16 checks passed
@JPeer264
JPeer264 deleted the jp/conv-http-target-transform branch August 28, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants