Skip to content

fix(size): Skip empty image files and demote UnidentifiedImageError logging #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-e merged 1 commit into from
Jun 4, 2026
Merged

fix(size): Skip empty image files and demote UnidentifiedImageError logging #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/launchpad/size/insights/apple/image_optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

import pillow_heif # type: ignore

from PIL import Image, ImageFile
from PIL import Image, ImageFile, UnidentifiedImageError

from launchpad.size.insights.insight import Insight, InsightsInput
from launchpad.size.models.apple import AppleAppInfo
Expand Down Expand Up @@ -121,6 +121,10 @@ def _analyze_image_optimization(
logger.info("Skipping %s because it has no full path", file_info.path)
return None

if file_info.size == 0:
logger.info("Skipping %s because it is empty (0 bytes)", file_info.path)
return None

try:
with Image.open(file_info.full_path) as img:
img.load() # type: ignore
Expand Down Expand Up @@ -159,6 +163,9 @@ def _analyze_image_optimization(
idiom=file_info.idiom,
colorspace=file_info.colorspace,
)
except UnidentifiedImageError:
logger.warning("Skipping %s: cannot identify image format", file_info.path)
return None
except Exception:
logger.exception("Failed to open or process image file")
return None
Expand Down
Loading