fix(size): Skip empty image files and demote UnidentifiedImageError logging#629
Merged
Merged
Conversation
Contributor
Author
📲 Install BuildsiOS
Android
|
trevor-e
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
UnidentifiedImageErroroccurring inlaunchpad.size.insights.apple.image_optimization._analyze_image_optimization.Problem:
The image optimization process was encountering
UnidentifiedImageErrorwhen attempting to open zero-byte image files, particularlyic_tick.pngand similar placeholder assets found in Flutter app bundles. ThePIL.Image.open()function cannot identify the format of an empty file, leading to an error.Root Cause:
The
_analyze_image_optimizationfunction did not include a check for zero-byte files before attempting to open them withPIL.Image.open(). While it guarded againstfull_pathbeingNone, it did not account for valid paths pointing to empty files. The existingexcept Exceptionblock logged these as errors, causing significant Sentry noise.Solution:
if file_info.size == 0:at the beginning of_analyze_image_optimization. If a file is zero-byte, it is now logged atinfolevel and skipped, preventingUnidentifiedImageErrorfor the most common cases.UnidentifiedImageErrorand changed its logging level fromexception(which creates Sentry errors) towarning. This reduces Sentry noise for any remaining edge cases where PIL cannot identify an image, without masking other critical exceptions.UnidentifiedImageErroris explicitly imported fromPILfor proper handling.Fixes LAUNCHPAD-5Y