Skip to content

fix: avoid host widget state races #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UnlastingR merged 1 commit into from
Aug 23, 2026
Merged

fix: avoid host widget state races #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ui/card-persistence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ export interface OpenAIWidgetStateBridge {
toolOutput?: unknown;
toolResponseMetadata?: unknown;
widgetState?: unknown;
setWidgetState?: (state: unknown) => void;
// Kept for host capability diagnostics only. DevSpace deliberately treats
// ChatGPT widget state as read-only: authoritative card persistence lives in
// the server-side card store, avoiding host-side widget_state write races.
setWidgetState?: (state: unknown) => Promise<void> | void;
}

export interface OpenAICardReference {
Expand Down
32 changes: 1 addition & 31 deletions src/ui/workspace-app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
cardInvocationFromHostContext,
cardReferenceFromOpenAIHost,
persistedCardFromOpenAIHost,
widgetStateWithPersistedCard,
type OpenAIWidgetStateBridge,
} from "./card-persistence.js";
import {
Expand Down Expand Up @@ -83,7 +82,7 @@ if (!maybeAppRoot) {
const appRoot = maybeAppRoot;

const CARD_PROBE_PREFIX = "[DevSpace card-probe]";
const CARD_PROBE_BUILD = "card-race-v3";
const CARD_PROBE_BUILD = "card-race-v4";

void boot();

Expand Down Expand Up @@ -139,7 +138,6 @@ async function boot(): Promise<void> {
const nextCard = { ...structured, tool };
card = nextCard;
cardOrigin = "tool-result";
persistCard(nextCard);
expanded = isInitiallyExpandedCard(nextCard);
reviewFilesExpanded = false;
openWorkspaceInstructionKey = null;
Expand Down Expand Up @@ -398,7 +396,6 @@ function restoreStoredCard(
openWorkspaceInstructionKey = null;
showAvailableWorkspaceInstructions = false;
errorMessage = null;
persistCard(restored);
logCardProbe("store-restore-hit", {
trigger,
tool: restored.tool,
Expand Down Expand Up @@ -463,33 +460,6 @@ function clearCardForRestore(): void {
errorMessage = null;
}

function persistCard(nextCard: ToolResultCard): void {
const bridge = openAIWidgetBridge();
if (typeof bridge?.setWidgetState !== "function") {
logCardProbe("host-persist-skip", {
tool: nextCard.tool,
cardId: nextCard.cardId,
});
return;
}

try {
bridge.setWidgetState(widgetStateWithPersistedCard(bridge.widgetState, nextCard));
logCardProbe("host-persist-called", {
tool: nextCard.tool,
cardId: nextCard.cardId,
});
} catch (persistError) {
logCardProbe("host-persist-failed", {
tool: nextCard.tool,
cardId: nextCard.cardId,
error: persistError instanceof Error ? persistError.message : String(persistError),
});
// ChatGPT widget persistence is an optional host extension. A host-side
// failure must never prevent the portable MCP Apps card from rendering.
}
}

function probeRecord(value: unknown): Record<string, unknown> | undefined {
return value && typeof value === "object" && !Array.isArray(value)
? value as Record<string, unknown>
Expand Down