Alert ergonomics

lib/Synergy/Reactor/PagerDuty.pm

@@ -524,7 +524,7 @@ responder 'give-oncall' => {
 command ack => {
   help => '*ack all*: acknowledge all triggered alerts in PagerDuty',
 } => async sub ($self, $event, $rest) {
-  unless ($rest && $rest eq 'all') {
+  if ($rest && $rest ne 'all') {
     return await $event->error_reply(q{The only thing you can "ack" is "all".});
   }
 
@@ -580,15 +580,18 @@ command resolve => {
     });
   }
 
-  return await $event->error_reply("I don't know what you want to ack.  Check the help!");
+  return await $event->error_reply("I don't know what you want to resolve.  Check the help!");
 };
 
 command snooze => {
-  help => 'Snooze a single PagerDuty incident. Usage: snooze ALERT-NUMBER for DURATION',
+  help => 'Snooze a PagerDuty incidents. Usage:
+
+  snooze ALERT-NUMBER for DURATION
+  snooze all for DURATION',
 } => async sub ($self, $event, $rest) {
-  my ($num, $dur) = $rest =~ /^#?(\d+)\s+for\s+(.*)/i;
+  my ($incident, $dur) = $rest =~ /^#?(\S+)\s+for\s+(.*)/i;
 
-  unless ($num && $dur) {
+  unless ($incident && $dur) {
     return await $event->error_reply(
       "Sorry, I don't understand. Say 'snooze INCIDENT-NUM for DURATION'."
     );
@@ -602,32 +605,42 @@ command snooze => {
 
   my @incidents = await $self->_get_incidents(qw(triggered acknowledged));
 
-  my ($relevant) = grep {; $_->{incident_number} == $num } @incidents;
-  unless ($relevant) {
-    return await $event->error_reply("I couldn't find an active incident for #$num");
+  # select a single incident if we
+  my @relevant = ($incident =~ /\d+/) ? grep {; $_->{incident_number} == $incident } @incidents : @incidents;
+
+  unless (@relevant) {
+    return await $event->error_reply("I couldn't find an active incident for '$incident'");
   }
 
-  my $id = $relevant->{id};
+  my @snoozed;
+  my @errors;
 
-  my $res = await $self->_pd_request_for_user(
-    $event->from_user,
-    POST => "/incidents/$id/snooze",
-    { duration => $seconds }
-  );
+  for my $item (@relevant) {
 
-  if (my $incident = $res->{incident}) {
-    my $title = $incident->{title};
-    my $duration = duration($seconds);
-    return await $event->reply(
-      "#$num ($title) snoozed for $duration; enjoy the peace and quiet!"
-    );
+    my $id = $item->{id};
+
+    my $res = eval { await $self->_pd_request_for_user(
+      $event->from_user,
+      POST => "/incidents/$id/snooze",
+      { duration => $seconds }
+    ); };
+    my $error = $@;
+
+    if (my $incident = $res->{incident}) {
+      my $title = $incident->{title};
+      push @snoozed, "#$id ($title)";
+    } else {
+      push @errors, $error->message;
+    }
   }
 
-  my $msg = $res->{message} // 'nothing useful';
+  my $reply = sprintf("Snoozed incidents for %s: \n%s", duration($seconds), join("\n", @snoozed));
 
-  return await $event->reply(
-    "Something went wrong talking to PagerDuty; they said: $msg"
-  );
+  if (@errors) {
+    $reply .= sprintf("\n\nUnfortunately we also received errors:\n%s", join("\n", @errors));
+  }
+
+  return await $event->reply($reply);
 };
 
 sub state ($self) {
@@ -687,7 +700,7 @@ sub _pd_request ($self, $method, $endpoint, $data = undef, $token = undef) {
     unless ($res->is_success) {
       my $code = $res->code;
       $Logger->log([ "error talking to PagerDuty: %s", $res->as_string ]);
-      return Future->fail('http', { http_res => $res });
+      return Future->fail($res->as_string, 'http', { http_res => $res });
     }
 
     my $data = decode_json($res->content);