Skip to content

Alert ergonomics - #291

Merged
lerlacher-fm merged 4 commits into
fastmail:mainfrom
lerlacher-fm:le-plat-4458-alerts-ergonomics
Aug 24, 2026
Merged

Alert ergonomics#291
lerlacher-fm merged 4 commits into
fastmail:mainfrom
lerlacher-fm:le-plat-4458-alerts-ergonomics

Conversation

@lerlacher-fm

@lerlacher-fm lerlacher-fm commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Two changes to PagerDuty reactor commands:

  • the only thing you can ack is 'all': There is no point in enforcing 'ack all'. Any ack shall ack.
  • snooze all: If 'all' is passed instead of an incident number, snooze everything

@lerlacher-fm
lerlacher-fm force-pushed the le-plat-4458-alerts-ergonomics branch from 0729558 to 830cd26 Compare August 12, 2026 22:25
@lerlacher-fm

Copy link
Copy Markdown
Contributor Author

@rjbs Before I spend time testing the implementation, do you have any objections to the behavior change I'm proposing here?

@rjbs

rjbs commented Aug 12, 2026

Copy link
Copy Markdown
Member

Nope!

@lerlacher-fm

Copy link
Copy Markdown
Contributor Author

Testing seems ok:

snooze #41478 for 1 hour
LOG | message event from term-rw/u:lerlacher: snooze #41478 for 1 hour
╭─────┤ term-rw!sysop ├───────────────────────────────────────────────────────╮
│ Snoozed incidents for 1 hour: 
│ #Q0X18OP6VRORZF (phl-root-02 - movemate is restarting too fast)
╰─────────────────────────────────────────────────────────────────────────────╯
snooze all for 48 hours
LOG | message event from term-rw/u:lerlacher: snooze all for 48 hours
╭─────┤ term-rw!sysop ├───────────────────────────────────────────────────────╮
│ Snoozed incidents for 2 days: 
│ #Q0X18OP6VRORZF (phl-root-02 - movemate is restarting too fast)
╰─────────────────────────────────────────────────────────────────────────────╯

ack
LOG | message event from term-rw/u:lerlacher: ack
LOG | PagerDuty: acking incidents: {{[]}}
╭─────┤ term-rw!sysop ├───────────────────────────────────────────────────────╮
│ Successfully acked 0 incidents. Good luck!
╰─────────────────────────────────────────────────────────────────────────────╯
ack all
LOG | message event from term-rw/u:lerlacher: ack all
LOG | PagerDuty: acking incidents: {{[]}}
╭─────┤ term-rw!sysop ├───────────────────────────────────────────────────────╮
│ Successfully acked 0 incidents. Good luck!
╰─────────────────────────────────────────────────────────────────────────────╯
ack nothing
LOG | message event from term-rw/u:lerlacher: ack nothing
LOG | PagerDuty: acking incidents: {{[]}}
╭─────┤ term-rw!sysop ├───────────────────────────────────────────────────────╮
│ Successfully acked 0 incidents. Good luck!
╰─────────────────────────────────────────────────────────────────────────────╯

@lerlacher-fm
lerlacher-fm marked this pull request as ready for review August 13, 2026 01:28
Comment thread lib/Synergy/Reactor/PagerDuty.pm Outdated
Comment thread lib/Synergy/Reactor/PagerDuty.pm Outdated
Comment thread lib/Synergy/Reactor/PagerDuty.pm
Comment thread lib/Synergy/Reactor/PagerDuty.pm
Comment thread lib/Synergy/Reactor/PagerDuty.pm
Comment thread lib/Synergy/Reactor/PagerDuty.pm Outdated
@lerlacher-fm
lerlacher-fm force-pushed the le-plat-4458-alerts-ergonomics branch 2 times, most recently from e7f004d to 052d456 Compare August 24, 2026 04:03
There is no point in enforcing 'ack all'. Any ack shall ack, unless it's
gobbledygook.
If 'all' is passed instead of an incident number, snooze everything
@lerlacher-fm
lerlacher-fm force-pushed the le-plat-4458-alerts-ergonomics branch from 052d456 to c7da09d Compare August 24, 2026 04:06
@lerlacher-fm
lerlacher-fm merged commit c106e07 into fastmail:main Aug 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants