Alert ergonomics - #291
Merged
lerlacher-fm merged 4 commits intoAug 24, 2026
Merged
Conversation
lerlacher-fm
force-pushed
the
le-plat-4458-alerts-ergonomics
branch
from
August 12, 2026 22:25
0729558 to
830cd26
Compare
Contributor
Author
|
@rjbs Before I spend time testing the implementation, do you have any objections to the behavior change I'm proposing here? |
Member
|
Nope! |
Contributor
Author
|
Testing seems ok: |
lerlacher-fm
marked this pull request as ready for review
August 13, 2026 01:28
lerlacher-fm
force-pushed
the
le-plat-4458-alerts-ergonomics
branch
2 times, most recently
from
August 24, 2026 04:03
e7f004d to
052d456
Compare
There is no point in enforcing 'ack all'. Any ack shall ack, unless it's gobbledygook.
If 'all' is passed instead of an incident number, snooze everything
lerlacher-fm
force-pushed
the
le-plat-4458-alerts-ergonomics
branch
from
August 24, 2026 04:06
052d456 to
c7da09d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to PagerDuty reactor commands: