Repository navigation
Conversation
akira28
added this pull request to stack #4315
October 6, 2026 06:34
akira28
changed the title
akira28
force-pushed
the
api-explorer-unions/allof-multi-ref
branch
from
October 6, 2026 07:02
2c192bf to
d333862
Compare
akira28
force-pushed
the
api-explorer-unions/allof-oneof
branch
from
October 6, 2026 07:02
f0557e4 to
632b3a4
Compare
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4314/ |
akira28
force-pushed
the
api-explorer-unions/allof-oneof
branch
from
October 6, 2026 11:31
632b3a4 to
416c4e5
Compare
akira28
force-pushed
the
api-explorer-unions/allof-multi-ref
branch
from
October 6, 2026 11:31
d333862 to
c7b4898
Compare
akira28
marked this pull request as ready for review
October 6, 2026 11:42
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
akira28
force-pushed
the
api-explorer-unions/allof-oneof
branch
from
October 6, 2026 13:14
416c4e5 to
9fa12ac
Compare
akira28
force-pushed
the
api-explorer-unions/allof-multi-ref
branch
from
October 6, 2026 13:14
c7b4898 to
5d209b6
Compare
An `allOf` with several `$ref` members showed only the first as the type, so the others were invisible. Property rows now add an "Also includes" line for the remaining object schemas, in HTML and Markdown. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
An `allOf` that repeated its first `$ref` listed that schema under "Also includes", although it already names the type. The list now leaves out the primary schema. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
akira28
force-pushed
the
api-explorer-unions/allof-multi-ref
branch
from
October 6, 2026 13:35
5d209b6 to
3c0a6d8
Compare
akira28
force-pushed
the
api-explorer-unions/allof-oneof
branch
from
October 6, 2026 13:35
9fa12ac to
35db829
Compare
akira28
removed this pull request from stack #4315
October 6, 2026 13:51
Contributor
Author
|
Superseded by #4327, which joins all seven PRs of this stack into one. The commits and the resolved review threads carry over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A property whose
allOfmerges several$refschemas now lists the extra ones in an "Also includes" line. Before, only the first schema appeared.Affects: API reference
Prompt summary: Improve how the API Explorer renders
anyOf,oneOfandallOf, one fix per stacked PR. This PR covers the second:allOfwith more than one$ref.Why
The type label of an
allOfnames only its first$ref. The other members still contribute properties to the list below, but nothing says where they come from.What
"Also includes" line
A property row lists the remaining object schemas of an
allOfafter the first, as links when they have their own page. Enums and primitive aliases are left out, because they say nothing about the object's shape. A single-$refallOfis unchanged.Markdown export
The Markdown output writes the same list as
Also includes: …, so the HTML and Markdown views stay in step.Type information
TypeInfocarries the extra schemas asAlsoIncludes.ApiPropertyTreeBuilderturns them into links forApiProperty.Verify
Out of scope: the schema pages (
SchemaView) and the CSS for the new row, which reuses existing classes. I haven't viewed the rendered row in a browser.Stack: 2 of 2, on top of #4313.
🤖 Generated with Claude Code