Repository navigation
Conversation
akira28
added this pull request to stack #4315
October 6, 2026 08:37
akira28
changed the title
akira28
force-pushed
the
api-explorer-unions/any-of-label
branch
from
October 6, 2026 11:31
b609ebe to
6ac4941
Compare
akira28
force-pushed
the
api-explorer-unions/discriminator-values
branch
from
October 6, 2026 11:31
6d8e686 to
0ca2cc9
Compare
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4319/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
akira28
force-pushed
the
api-explorer-unions/any-of-label
branch
from
October 6, 2026 13:13
6ac4941 to
a4c0c47
Compare
akira28
force-pushed
the
api-explorer-unions/discriminator-values
branch
from
October 6, 2026 13:14
0ca2cc9 to
859455f
Compare
Property and parameter rows said "One of:" for every union, although an `anyOf` value can match several options at once. The union now carries its schema keyword, and rows read "Any of:" for `anyOf` and "One of:" for `oneOf`, in HTML and Markdown. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The test printed a debug dump of every property row that its assertions already cover. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
akira28
force-pushed
the
api-explorer-unions/discriminator-values
branch
from
October 6, 2026 13:35
859455f to
4e59fdd
Compare
akira28
force-pushed
the
api-explorer-unions/any-of-label
branch
from
October 6, 2026 13:35
a4c0c47 to
a7fab59
Compare
akira28
removed this pull request from stack #4315
October 6, 2026 13:51
Contributor
Author
|
Superseded by #4327, which joins all seven PRs of this stack into one. The commits and the resolved review threads carry over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rows for
anyOfunions in the API reference now read "Any of:" instead of "One of:".oneOfunions keep "One of:".Affects: API reference
Prompt summary: Improve how the API Explorer renders
anyOf,oneOfandallOf, one fix per stacked PR. This PR covers the fourth: tellinganyOfapart fromoneOfon property and parameter rows.Why
A value of an
anyOftype can match several options at once. A value of aoneOftype matches exactly one. Every row said "One of:", so a reader could not tell a choice from a combination.What
Union keyword on the type
TypeInforecords whether a union came fromoneOforanyOf. Both the inline path and the$refpath set it. When a schema has both keywords,oneOfwins, as it already did for the options.Row label
Property rows, path parameters and query parameters take their label from that keyword through
SchemaHelpers.UnionLabel. The Markdown export uses the same label, so both views agree.Verify
Out of scope: the expanded variant list, which separates variants with "or" for both keywords, and the "Union Types" headings on schema pages, which already name the keyword. I haven't viewed the label on a rendered page.
Stack: 4 of 4, on top of #4317, #4314 and #4313.
🤖 Generated with Claude Code