Skip to content

Refactor image rotation and PNG format logic #33140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kubaflo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

Refactor image rotation and PNG format logic #33140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/Essentials/src/MediaPicker/MediaPicker.ios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,17 +611,13 @@ internal CompressedUIImageFileResult(UIImage image, string originalFileName = nu
bool ShouldUsePngFormat()
{
// Use PNG if:
// 1. High quality (>=90) and no resizing needed (preserves original format)
// 2. Original file was PNG
// 3. Image might have transparency (PNG supports alpha channel)
// 1. Original file was PNG
// 2. High quality (>=90) and no resizing needed (preserves original format)

bool highQualityNoResize = compressionQuality >= 90 && !maximumWidth.HasValue && !maximumHeight.HasValue;
bool originalWasPng = !string.IsNullOrEmpty(originalFileName) &&
(originalFileName.EndsWith(".png", StringComparison.OrdinalIgnoreCase) ||
originalFileName.EndsWith(".PNG", StringComparison.OrdinalIgnoreCase));
Path.GetExtension(originalFileName).Equals(".png", StringComparison.OrdinalIgnoreCase);

// For very high quality or when original was PNG, preserve PNG format
return (compressionQuality >= 95 && !maximumWidth.HasValue && !maximumHeight.HasValue) || originalWasPng;
return originalWasPng || (compressionQuality >= 90 && !maximumWidth.HasValue && !maximumHeight.HasValue);
}

internal override Task<Stream> PlatformOpenReadAsync()
Expand Down
Loading