Refactor image rotation and PNG format logic #33140
Open
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved comments for clarity in image rotation logic. Updated ShouldUsePngFormat to prioritize original PNG files and clarified the conditions for preserving PNG format.
Contributor
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the PNG format detection logic in the iOS MediaPicker to improve clarity and fix inconsistencies. The changes prioritize preserving PNG format for original PNG files and align the quality threshold comment with the actual implementation (90 instead of 95).
Key Changes:
- Simplified PNG extension check using
Path.GetExtension()instead of multipleEndsWith()calls - Reordered logic to prioritize original PNG files first
- Aligned compression quality threshold from 95 to 90 to match the comment and unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved comments for clarity in image rotation logic. Updated ShouldUsePngFormat to prioritize original PNG files and clarified the conditions for preserving PNG format.
Fixes #33119