fix incorrect correct reason element in chkData#86
Merged
Conversation
The schemas for domain, host, and contact mapping are as follows:
```
<!-- Used as type for <domain:cd> -->
<complexType name="checkType">
<sequence>
<element name="name" type="domain:checkNameType"/>
<element name="reason" type="eppcom:reasonType"
minOccurs="0"/>
</sequence>
</complexType>
```
```
<!-- Used as type for <host:cd> -->
<complexType name="checkType">
<sequence>
<element name="name" type="host:checkNameType"/>
<element name="reason" type="eppcom:reasonType"
minOccurs="0"/>
</sequence>
</complexType>
```
```
<!-- Used as type for <contact:cd> -->
<complexType name="checkType">
<sequence>
<element name="id" type="contact:checkIDType"/>
<element name="reason" type="eppcom:reasonType"
minOccurs="0"/>
</sequence>
</complexType>
```
Before this fix, the parser expected the reason to be an attribute.
This fixes this shortcoming and also brings some of the struct names and
field names closer to the schema.
This avoids situations where you have to write `results.list[0].id.id` when contact::CheckData. Changes all other equivalent structs to be consistent.
djc
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schemas for domain, host, and contact mapping are as follows:
Before this fix, the parser expected the reason to be an attribute.
This fixes this shortcoming and also brings some of the struct names and
field names closer to the schema.