Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
- Coverage 83.42% 83.42% -0.01%
==========================================
Files 248 248
Lines 51262 51280 +18
Branches 4431 4438 +7
==========================================
+ Hits 42765 42779 +14
- Misses 7735 7736 +1
- Partials 762 765 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FabioLuporini
left a comment
There was a problem hiding this comment.
Approved (test in PRO I'd imagine?)
EdCaunt
left a comment
There was a problem hiding this comment.
Seems reasonable. What caused you to find this out of curiosity?
a3822f4 to
812b7fd
Compare
devito/ir/equations/algorithms.py
Outdated
| kwargs['functions'] = functions | ||
|
|
||
| mapper[d] = d._rebuild(**kwargs) | ||
| mapper.update({tkn0: tkn1 for tkn0, tkn1 in zip(d.thickness, tkns, strict=True)}) |
There was a problem hiding this comment.
doesn't mapper.update(zip(...)) just work ?
There was a problem hiding this comment.
Yeah, you can do that. I think I didn't realise when I first made concretize_subdims so this is probably just following on from that
812b7fd to
20c50cc
Compare
1c6b3bd to
5c5ebcf
Compare
5c5ebcf to
9c7a360
Compare
No description provided.