Skip to content

compiler: fix msd thickness lowering#2834

Open
mloubout wants to merge 2 commits intomainfrom
msd-tkns-fix-mapper
Open

compiler: fix msd thickness lowering#2834
mloubout wants to merge 2 commits intomainfrom
msd-tkns-fix-mapper

Conversation

@mloubout
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.42%. Comparing base (c189f61) to head (9c7a360).

Files with missing lines Patch % Lines
devito/passes/clusters/blocking.py 45.45% 3 Missing and 3 partials ⚠️
devito/passes/clusters/implicit.py 0.00% 3 Missing ⚠️
devito/ir/equations/algorithms.py 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   83.42%   83.42%   -0.01%     
==========================================
  Files         248      248              
  Lines       51262    51280      +18     
  Branches     4431     4438       +7     
==========================================
+ Hits        42765    42779      +14     
- Misses       7735     7736       +1     
- Partials      762      765       +3     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.74% <21.42%> (-0.03%) ⬇️
pytest-gpu-gcc- 78.01% <73.80%> (-0.01%) ⬇️
pytest-gpu-icx- 77.62% <73.80%> (-0.01%) ⬇️
pytest-gpu-nvc-nvidiaX 69.26% <21.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (test in PRO I'd imagine?)

Copy link
Copy Markdown
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. What caused you to find this out of curiosity?

@mloubout mloubout force-pushed the msd-tkns-fix-mapper branch 2 times, most recently from a3822f4 to 812b7fd Compare March 11, 2026 13:06
kwargs['functions'] = functions

mapper[d] = d._rebuild(**kwargs)
mapper.update({tkn0: tkn1 for tkn0, tkn1 in zip(d.thickness, tkns, strict=True)})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't mapper.update(zip(...)) just work ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you can do that. I think I didn't realise when I first made concretize_subdims so this is probably just following on from that

@mloubout mloubout force-pushed the msd-tkns-fix-mapper branch from 812b7fd to 20c50cc Compare March 23, 2026 14:13
@mloubout mloubout force-pushed the msd-tkns-fix-mapper branch 8 times, most recently from 1c6b3bd to 5c5ebcf Compare March 30, 2026 17:06
@mloubout mloubout force-pushed the msd-tkns-fix-mapper branch from 5c5ebcf to 9c7a360 Compare March 31, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants