Repository navigation
Conversation
CHANGES REQUIRED — proposed architecture reviewReviewed head: P2 — Catalog withdrawal must not close existing allocations' ordinary operation admissionLocation: The proposal groups catalog withdrawal with suspension/provider retirement and says it “closes ordinary admission.” In this protocol ordinary admission includes new operations, sessions and boot grants against an existing Allocation. That contradicts the pinned retained-capability contract: #58 lines 288–303 explicitly distinguishes acquisition withdrawal from runtime restrictions, and #59 lines 1107–1110 requires preserving retained runtime capabilities. #62's operation admission and #64's operation-authority sections preserve that distinction too. Concrete counterexample: Allocation A is active with retained reinstall/power capabilities and valid current action/input permissions. Its provider removes the offering from the catalog to stop new sales, without suspending A or retiring the provider. An implementation following lines 110–111 closes A's ordinary operation/session admission, rejecting an otherwise authorized power operation or reinstall. Neither a release decision nor a runtime restriction exists. Merely avoiding erasure does not preserve the accepted contract. Minimum fix: Split the triggers explicitly: catalog/offering/assignment withdrawal closes new acquisition only, leaving existing allocations' retained runtime capabilities and service cleanup intact; explicit suspension/safety restrictions close their specified affected runtime actions; provider retirement closes acquisition and ordinary runtime admission under ProviderGuard. Make the same distinction in the failure matrix, and add a scenario asserting that a currently authorized action on an existing allocation remains admissible after catalog-only withdrawal while a new allocation is rejected. No weakening of release's R1 closure is needed. Adversarial coverage and qualification boundaryI read the complete release proposal and checked its relevant contracts against the pinned #41/#51/#58–#64 sources, including #59 PXE, plus AGENTS.md, README.md and architecture context. The concrete release traces otherwise fail closed: admission versus pre-closure sends is ordered and inventoried; late callbacks/outboxes/paused brokers and persistent BMC commands require boundary settlement; RAM installers require independent physical stop; session/console/PXE and cleaner access require effective revocation; #61's exact disconnect, durable no-reuse and per-assignment disposition barriers are consumed; missing/swapped media cannot be replaced by another disk's erase evidence; firmware/BMC restoration and old-credential denial remain separate predicates. I also checked evidence expiry/invalidation before and after R2, shared ledger lock ordering, deletion with protected cleanup/key/input custody, quota acknowledgment independent of fresh reuse eligibility, permanent tombstones/new allocation identities, restore epochs and old-writer fencing, and external-provider LockedClean/R3/unavailability. I did not identify an additional concrete transition that permits premature reusable capacity under the stated qualification assumptions. Independent physical stop, trustworthy component coverage, irreversible downstream barriers, protected recovery infrastructure and provider emergency-access agreements are explicit enablement prerequisites—not claims of implemented or physically verified guarantees, and not findings merely because their implementations are deferred. This is a request to correct a contradictory architectural contract, not a formal approval or runtime/hardware/platform sign-off. No repository edits or runtime tests were performed; |
ARCHITECTURAL SIGN-OFF — proposed architecture onlyReviewed exact head: Prior P2 resolvedThe authorization paragraph, lines 105–116, separate failure-matrix cases at lines 548–549, and qualification scenario at lines 561–565 now preserve the pinned #58/#60 distinction between acquisition access and retained runtime capabilities. Replaying the original counterexample: an active allocation retains its accepted power/reinstall capabilities after catalog-only withdrawal; a currently authorized runtime action is not rejected merely because acquisition access disappeared. Withdrawal creates neither a runtime gate closure nor a ReleaseCase. A separately effective runtime suspension rejects its affected action, and provider retirement closes ordinary admission under ProviderGuard; neither alone authorizes wiping. R1's authorized irreversible release closure remains intact. The acquisition rule still consumes #58's effective combined-grant evaluation: removing one redundant assignment does not erase another valid grant. Complete-protocol adversarial reviewI found no additional architectural blockers under the stated qualification assumptions. In particular, the following attempted counterexamples remain blocked:
I read AGENTS.md, README.md, the architecture context, the full release proposal, and relevant pinned contracts from #41, #51, #58, #59 including PXE, #60, #61, #62, #63 and #64. The #63/#64 interfaces remain draft dependencies, not owner approval. Qualification boundary and validationIndependent physical stop/queue clearance, trustworthy media/component coverage, effective downstream barriers, protected journals/keys/restore authority, lifecycle/quota interlocks, and provider emergency-access agreements are explicit enablement prerequisites. Their deferred implementation is not itself a design hole: unsupported or unverifiable cases remain unavailable rather than being promoted to readiness. These obligations must be implemented and qualified before enablement; this review does not establish that they exist or work. The complete proposal diff passes |
Summary
Release, reuse and custody: proposed documentation only. Select release-owned R1 closure, complete obligation inventory, qualified execution/network/data/credential settlement, accounting acknowledgment, R2 clearance and separate external R3/fresh reuse gates. Retain explicit adopted authorization and real-accounting or positive non-applicability proof.
Add PhysicalMaintenance clearance using the same ReleaseCase/slot and optional supply fields. Require permit/crew cessation, physical disposition, dependency-owner barriers and accounting provenance. Qualified passive policy does not fabricate boot/media/cleaning requirements. R2 clears only its subject, preserves destination interests and dependent obligations, and cannot publish eligibility. Add qualification cases 16–18.
Remaining P2 response and preserved boundaries
Responds to the exact fresh complete-set review. The earlier commissioning/adopted-settlement findings remain resolved in the proposed contracts; this revision does not replace them with maintenance.
physical-maintenance-v1adds one explicit subject to the existing shared custody/slot/journal/release protocol, not a second allocator or executor.No runtime implementation, core #41/#51/#58/#59 change, managed-service scope, compatibility machinery, new PR, merge, watch or self-signoff. This existing branch remains based on
origin/mainat8ebec19513a0cbc8f219d3acae46f89ab471510b; companion branch diffs are not imported.Exact final complete-set manifest
f04e63ddd9d10cbf306daf3a0232961debd85e7ffa07c2236801a33a58efc914b555586c8e146cc6a922ff1eb3275e26af6ae750a7515ddde245a754d7ff793b03711203dbfc9fac87d43922cc649b6f80c72446a574202c9dac5f6d3c26ce4a0af875ba8101f645cc8167f71a07147e6ea1a9cdf69a57cf496ec4530aa3bacdb4858d0b22192be1a92b0c48ce4a30a36ee476073281b40b8353ac5eb2c99e0c4495e20f4c3ee7697dfd97a5a95823ca5fa7b44894824bf7ef614fcdecf3ce813c289e259367e90cffe6ed28e261578bbc3d0226585b5e80f5d5985cThis PR's final head is
94824bf7ef614fcdecf3ce813c289e259367e90c. Core heads are unchanged. #60–#65 pin immutable contract-bearing snapshots; #66 pins their final source heads. Post-contract commits refresh only pins/review provenance, avoiding circular final-head dependencies. Older embedded pins in snapshots are drafting history, not authority to substitute an older contract for this aligned set.4bf770db8bd2b065748c3b9384d4c72f9b8ec0e125fef48790b13da95900de64ffd2d1b36e0510eb4f9934980b3f441c1d777157fa0ba1dcfce372d72b384517fd08c04cf078923ebda2cddcfa1dc42458a6596d30b3819d0b3799192730626439ef9885310a55d97394bb296c579bd3ad01177455c15cc426601c7121542d7c89ddac84c1f8592f08cb8372Documentation validation
git merge-tree/commit objects only: conflict-free; no branch or PR merge and no shell worktree. Combined treec5c26cf30c2ee1f974404576220c106ad32961f2, local validation commit036e40a0573be61b506fff7e8604bac4377117a0.Remaining prerequisites and review status
Fresh independent complete-set integration review is required for this exact changed manifest; no previous approval or author check signs off these revisions. Implementation still needs the shared ledger hooks and synchronous storage/restore interlocks, independent R/KMS/PKI and physical fences, registered owner gates, protected inputs/evidence, qualified online field permits and site/crew exclusion, active-custody/network owner agreements, accounting applicability proofs, measured profile limits and real qualification/drills. QP does not qualify compute or supplier execution. R-history-loss reactivation remains unsupported until separately implemented and qualified.
No runtime, hardware, provider, Q0/Q1/QP/QD/QE qualification, owner approval or independent signoff is claimed. Ready for the requested fresh independent review, not merge or deployment approval.