Repository navigation
Conversation
ARCHITECTURAL SIGN-OFFReviewed head 2563b2a, refreshed again before posting. Independent adversarial review of the complete allocation-admission proposal against the baseline lifecycle/source proposals and current #41/#51/#58/#59 heads (matching the pinned revisions). Scope: standalone Fleet/Metal only. No architectural blockers found under the explicitly required contracts. In particular:
This is design sign-off, not implementation verification or runtime/hardware readiness. IAM/Milo/quota, storage/recovery, executor, network and release-owner implementation and fault-injection qualification remain mandatory; production enablement must remain closed without them (lines 558–565, 632–650). This review neither substitutes for those owner approvals nor approves a merge. No source changes or approval review submitted. |
Summary
Allocation admission and custody: proposed documentation only. Select one SERIALIZABLE PostgreSQL admission ledger, registered close-before-change authority gates, protected charged escrow, immutable MachineBinding, canonical occupancy, ProviderGuard and transactional recovery outboxes. Keep runtime action/input rights distinct from offering acquisition. Preparation and adopted settlement remain explicit non-consumer custody paths.
Add PhysicalMaintenance to the existing AssetCustody/Occupancy union. Exact Device and optional supply, current custodian/service/technician authority, prior-work proof, dependency-owner barriers and all old/new physical keys participate in one ordered L1. Atomically reserve destination interests, retain old ones, close inventory, acquire custody/slot and retain inputs/outbox. No second allocator or synthetic compute/boot prerequisites.
Remaining P2 response and preserved boundaries
Responds to the exact fresh complete-set review. The earlier commissioning/adopted-settlement findings remain resolved in the proposed contracts; this revision does not replace them with maintenance.
physical-maintenance-v1adds one explicit subject to the existing shared custody/slot/journal/release protocol, not a second allocator or executor.No runtime implementation, core #41/#51/#58/#59 change, managed-service scope, compatibility machinery, new PR, merge, watch or self-signoff. This existing branch remains based on
origin/mainat8ebec19513a0cbc8f219d3acae46f89ab471510b; companion branch diffs are not imported.Exact final complete-set manifest
f04e63ddd9d10cbf306daf3a0232961debd85e7ffa07c2236801a33a58efc914b555586c8e146cc6a922ff1eb3275e26af6ae750a7515ddde245a754d7ff793b03711203dbfc9fac87d43922cc649b6f80c72446a574202c9dac5f6d3c26ce4a0af875ba8101f645cc8167f71a07147e6ea1a9cdf69a57cf496ec4530aa3bacdb4858d0b22192be1a92b0c48ce4a30a36ee476073281b40b8353ac5eb2c99e0c4495e20f4c3ee7697dfd97a5a95823ca5fa7b44894824bf7ef614fcdecf3ce813c289e259367e90cffe6ed28e261578bbc3d0226585b5e80f5d5985cThis PR's final head is
80c72446a574202c9dac5f6d3c26ce4a0af875ba. Core heads are unchanged. #60–#65 pin immutable contract-bearing snapshots; #66 pins their final source heads. Post-contract commits refresh only pins/review provenance, avoiding circular final-head dependencies. Older embedded pins in snapshots are drafting history, not authority to substitute an older contract for this aligned set.4bf770db8bd2b065748c3b9384d4c72f9b8ec0e125fef48790b13da95900de64ffd2d1b36e0510eb4f9934980b3f441c1d777157fa0ba1dcfce372d72b384517fd08c04cf078923ebda2cddcfa1dc42458a6596d30b3819d0b3799192730626439ef9885310a55d97394bb296c579bd3ad01177455c15cc426601c7121542d7c89ddac84c1f8592f08cb8372Documentation validation
git merge-tree/commit objects only: conflict-free; no branch or PR merge and no shell worktree. Combined treec5c26cf30c2ee1f974404576220c106ad32961f2, local validation commit036e40a0573be61b506fff7e8604bac4377117a0.Remaining prerequisites and review status
Fresh independent complete-set integration review is required for this exact changed manifest; no previous approval or author check signs off these revisions. Implementation still needs the shared ledger hooks and synchronous storage/restore interlocks, independent R/KMS/PKI and physical fences, registered owner gates, protected inputs/evidence, qualified online field permits and site/crew exclusion, active-custody/network owner agreements, accounting applicability proofs, measured profile limits and real qualification/drills. QP does not qualify compute or supplier execution. R-history-loss reactivation remains unsupported until separately implemented and qualified.
No runtime, hardware, provider, Q0/Q1/QP/QD/QE qualification, owner approval or independent signoff is claimed. Ready for the requested fresh independent review, not merge or deployment approval.