🛡️ Sentinel: [HIGH] Fixed insecure file creation permissions#384
🛡️ Sentinel: [HIGH] Fixed insecure file creation permissions#384acebytes wants to merge 1 commit into
Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d9011e6d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Write to temp file securely (0600) to prevent TOCTOU access | ||
| let fd = tmpURL.withUnsafeFileSystemRepresentation { pathPtr -> Int32 in | ||
| guard let pathPtr = pathPtr else { return -1 } | ||
| return open(pathPtr, O_CREAT | O_WRONLY | O_EXCL | O_CLOEXEC, 0o600) |
There was a problem hiding this comment.
When the helper or tests run under a restrictive process umask that masks owner bits (for example umask 0777), the mode passed to open is still filtered by that umask, so this can create and rename a journal with permissions like 000/0400 instead of the 0600 contract asserted by testJournalFilePermissions; flushState() still reports success, and non-root test readers can fail to reopen the file. Calling fchmod(fd, 0o600) after the successful open keeps creation non-world-readable while restoring the exact owner permissions before the rename.
Useful? React with 👍 / 👎.
1 participant
🚨 Severity: HIGH\n💡 Vulnerability: Fixed insecure file creation permissions\n🎯 Impact: Fixed insecure file creation permissions\n🔧 Fix: Fixed insecure file creation permissions\n✅ Verification: Verify by creating a file and checking permissions.
PR created automatically by Jules for task 16760960167982652000 started by @acebytes