Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@
## 2025-10-24 - Bulk Disk I/O Parallelization and Thread Pool Starvation
**Learning:** Both `withTaskGroup` and `Task.detached` schedule their work on Swift's cooperative thread pool, which has only as many threads as the CPU has cores. Running synchronous blocking I/O (like `FileManager.removeItem`) directly inside such tasks ties up cooperative threads β€” when every thread is parked in a syscall there is nothing left to advance other Swift Concurrency work, which manifests as starvation and (with self-referential `await` chains) outright deadlock. `Task.detached` does not help here: "detached" means unstructured/independent, not "off the cooperative pool."
**Action:** To parallelize bulk blocking I/O, combine a sliding-window `withThrowingTaskGroup` (e.g., `maxConcurrency` of 8) with a per-item handoff to a GCD queue: wrap the blocking call in `withCheckedThrowingContinuation` and dispatch it via `DispatchQueue.global(qos: .userInitiated).async { ... continuation.resume(...) }`. The cooperative-pool task only `await`s the continuation, so it never holds a thread while the syscall runs.
## 2024-05-24 - Optimize Collection Processing
**Learning:** `lazy.filter` shouldn't be chained into `count` or `isEmpty` without consideration, but instead of using `isEmpty` on `lazy.filter`, we can use `contains(where:)` to short circuit the execution to prevent evaluating all elements. Also for the `reduce` chaining after `lazy.filter`, we can chain `lazy.filter` before `.reduce` to avoid intermediate array allocations.
**Action:** Chain `.lazy.filter` before `.reduce` or use `contains(where:)` instead of `isEmpty` checks.
8 changes: 6 additions & 2 deletions Sources/Cacheout/ViewModels/CacheoutViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ class CacheoutViewModel: ObservableObject {
}

var selectedSize: Int64 {
selectedResults.reduce(0) { $0 + $1.sizeBytes }
// ⚑ Bolt Optimization: Use lazy filtering to prevent intermediate array allocation
scanResults.lazy.filter { $0.isSelected }.reduce(0) { $0 + $1.sizeBytes }
}

var formattedSelectedSize: String {
Expand All @@ -118,7 +119,10 @@ class CacheoutViewModel: ObservableObject {
}

var hasResults: Bool { !scanResults.isEmpty || !nodeModulesItems.isEmpty }
var hasSelection: Bool { !selectedResults.isEmpty || selectedNodeModulesSize > 0 }
var hasSelection: Bool {
// ⚑ Bolt Optimization: Use contains(where:) to short-circuit evaluation instead of checking .isEmpty on filtered arrays
scanResults.contains(where: \.isSelected) || selectedNodeModulesSize > 0
}

// MARK: - Node Modules computed properties

Expand Down
3 changes: 2 additions & 1 deletion Sources/Cacheout/Views/MenuBarView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ struct MenuBarView: View {
Spacer()
statPill(
label: "Categories",
value: "\(viewModel.scanResults.filter { !$0.isEmpty }.count)",
// ⚑ Bolt Optimization: Use .lazy.filter before .count to prevent intermediate array allocation
value: "\(viewModel.scanResults.lazy.filter { !$0.isEmpty }.count)",
color: .blue
)
}
Expand Down
Loading