fix: correct path references and env var names in agent README templates#364
Merged
fix: correct path references and env var names in agent README templates#364
Conversation
All 6 agent framework README templates referenced nonexistent paths (src/main.py, src/model/load.py, .agentcore) from an older layout. Updated to match the actual generated project structure (main.py, model/load.py, agentcore/). Also replaced hardcoded env var names (AGENTCORE_IDENTITY_OPENAI etc.) with dynamic Handlebars template using identityProviders.[0].envVarName, gated by hasIdentity so Bedrock projects omit the API key row. Added src/assets/**/*.md to .prettierignore since asset markdown files are Handlebars templates that prettier cannot parse correctly.
tejaskash
requested a deployment
to
e2e-testing
GitHub Actions
Waiting
The actual env file used is agentcore/.env.local (constant ENV_FILE in src/lib/constants.ts), not agentcore/.env.
tejaskash
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strands,crewai,autogen,langchain_langgraph,googleadk,openaiagents) that referenced nonexistent paths from an older project layout (src/main.py,src/model/load.py,.agentcore) — updated tomain.py,model/load.py,agentcore/AGENTCORE_IDENTITY_OPENAI,AGENTCORE_IDENTITY_ANTHROPIC,AGENTCORE_IDENTITY_GEMINI) with dynamic Handlebars template using{{identityProviders.[0].envVarName}}, gated by{{#if hasIdentity}}so Bedrock projects (IAM auth) correctly omit the API key rowsrc/assets/**/*.mdto.prettierignoresince asset markdown files contain Handlebars template syntax that prettier cannot parse correctlyTest plan
npm run test:update-snapshots— 6 snapshots updatedLOCAL_DEV