Repository navigation
wasm: the apply op, a diagram gesture as text edits - #30
Merged
Merged
Conversation
A page's diagram editor needs what beehive's VS Code editor has: a gesture on an element (ide.Index.Apply) turned into text edits, checked to read no worse. The op gives the edits and the source they make.
|
Thank you for the pull request. beedance is dual-licensed, so contributors sign the contributor licence agreement once. Please read it and, if you agree, reply with the sentence below. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Owner
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #29. This adds
{"op":"apply","source":S,"gesture":G}to the web module. It runside.Index.Apply, the gesture engine beehive's VS Code diagram editor uses, and replies{edits, source}. A gesture whose result reads worse than the source is refused with the reason.beespace's Diagrams tab uses it to edit LD, FBD and SFC bodies by selecting an element and pressing a key or button.
Tests:
TestApplycovers a contact added after a rung element, an unknown gesture, and a missing gesture. The wasm README anddoc/web-debugger.mddescribe the op.