Skip to content

test(dashboard): fix filter-delete queries broken by aria-label rename #41781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rusackas wants to merge 1 commit into from
Closed

test(dashboard): fix filter-delete queries broken by aria-label rename #41781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...end/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,7 @@ test('restores a deleted filter via the "Restore filter" button', async () => {

const filterContainer = screen.getByTestId('filter-title-container');
const firstTab = within(filterContainer).getAllByRole('tab')[0];
fireEvent.click(within(firstTab).getByRole('button', { name: /delete/i }));
fireEvent.click(within(firstTab).getByRole('button', { name: /remove filter/i }));

expect(
await screen.findByText(/you have removed this filter/i),
Expand Down Expand Up @@ -1009,7 +1009,7 @@ test('undoes a filter deletion via the sidebar "Undo?" link', async () => {

const filterContainer = screen.getByTestId('filter-title-container');
const firstTab = within(filterContainer).getAllByRole('tab')[0];
fireEvent.click(within(firstTab).getByRole('button', { name: /delete/i }));
fireEvent.click(within(firstTab).getByRole('button', { name: /remove filter/i }));

const undoButton = await screen.findByTestId('undo-button');
expect(undoButton).toHaveTextContent(/undo\?/i);
Expand Down
Loading