test(dashboard): fix filter-delete queries broken by aria-label rename

[rusackas]

SUMMARY

#41742 (merged 2026-07-03) fixed the filter icons to use a real aria-label instead of the non-functional alt prop, which changed the delete icon's accessible name from delete to "Remove filter" — but didn't update the two FiltersConfigModal tests that query the button by its accessible name. Since then, sharded-jest-tests (5) fails deterministically on any PR whose CI runs it (observed on #41780 and others):

TestingLibraryElementError: Unable to find an accessible element with the role "button" and name /delete/i
  Name "Remove filter": <span aria-label="Remove filter" data-test="delete" ... />

Two-line fix: update the getByRole('button', { name: ... }) queries in restores a deleted filter via the "Restore filter" button and undoes a filter deletion via the sidebar "Undo?" link to /remove filter/i.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — test-only.

TESTING INSTRUCTIONS

cd superset-frontend && npx jest src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx

26 passed, 1 skipped (pre-existing skip) locally.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[bito-code-review]

Code Review Agent Run #ddc012

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 82d2d76..82d2d76

  • superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	82d2d76
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6a4b16537f0093000886850b
😎 Deploy Preview	https://deploy-preview-41781--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[rusackas]

@sadpandajoe mind a quick look? Two-line test fix, but it unblocks sharded-jest-tests (5) for every open PR... it's been failing since #41742 landed on Thursday.

[hainenber]

@rusackas you might want to update master branch. I've landed a fix here ;D

[rusackas]

As it turns out, #41774 landed the same fix this morning (via REMOVE_FILTER_BUTTON_REGEX), so master's shard 5 is already unblocked. Closing as superseded... no action needed @sadpandajoe, sorry for the ping!