Skip to content

[Fix-18776][DAO] Fix @Param name of K8sNamespaceMapper#queryByNamespaceCode #18777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SbloodyS merged 1 commit into from
Nov 11, 2026
Merged

[Fix-18776][DAO] Fix @Param name of K8sNamespaceMapper#queryByNamespaceCode #18777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/K8sNamespaceMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,5 @@ IPage<K8sNamespace> queryK8sNamespacePaging(IPage<K8sNamespace> page,
* @param namespaceCode namespaceCode
* @return true if exist else return null
*/
K8sNamespace queryByNamespaceCode(@Param("clusterCode") Long namespaceCode);
K8sNamespace queryByNamespaceCode(@Param("namespaceCode") Long namespaceCode);
}
17 changes: 17 additions & 0 deletions ...uler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/K8sNamespaceMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,23 @@ public void testQueryByK8sNamespaceId() {
Assertions.assertEquals(entity, k8sNamespace);
}

/**
* test query k8s namespace by namespace code
*/
@Test
public void testQueryByNamespaceCode() {
K8sNamespace entity = insertOne();

K8sNamespace k8sNamespace = k8sNamespaceMapper.queryByNamespaceCode(entity.getCode());
Assertions.assertNotNull(k8sNamespace);
Assertions.assertEquals(entity.getId(), k8sNamespace.getId());
Assertions.assertEquals(entity.getCode(), k8sNamespace.getCode());
Assertions.assertEquals(entity.getNamespace(), k8sNamespace.getNamespace());
Assertions.assertEquals(entity.getClusterCode(), k8sNamespace.getClusterCode());

Assertions.assertNull(k8sNamespaceMapper.queryByNamespaceCode(entity.getCode() + 1));
}

/**
* test query k8sNamespaces list paging
*/
Expand Down
Loading