Repository navigation
[Fix-18776][DAO] Fix @Param name of K8sNamespaceMapper#queryByNamespaceCode - #18777
Merged
Merged
Conversation
…ceCode - Use @PARAM("namespaceCode") to match #{namespaceCode} in K8sNamespaceMapper.xml - Add K8sNamespaceMapperTest#testQueryByNamespaceCode
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md) |
|
Awesome work, congrats on your first merged pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
Yes. The parameter mismatch was discovered by a custom static MyBatis binding checker I built; AI assisted with independent cross-checking, and the fix and unit test were written and reviewed by the author.
Purpose of the pull request
Close #18776.
K8sNamespaceMapper#queryByNamespaceCodeannotated its parameter with@Param("clusterCode"), whileK8sNamespaceMapper.xmlreferences#{namespaceCode}, causing calls to fail withBindingException: Parameter 'namespaceCode' not found.Brief change log
@Param("namespaceCode")inK8sNamespaceMapper#queryByNamespaceCodeso that it matches the XML statement.K8sNamespaceMapperTest#testQueryByNamespaceCode.Verify this pull request
This change added tests and can be verified as follows:
K8sNamespaceMapperTest#testQueryByNamespaceCode(verified by the unit test suite in CI).Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md