Skip to content

chore: Add "Willingness to contribute" dropdown to issue templates - #26120

Merged
comphead merged 2 commits into
apache:mainfrom
comphead:issue-template-willingness-to-contribute
Oct 8, 2026
Merged

comphead merged 2 commits into
apache:mainfrom
comphead:issue-template-willingness-to-contribute

Conversation

@comphead

@comphead comphead commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • No tracking issue, this is a small repository chore.

Rationale for this change

Ports apache/datafusion-comet#6688, which took the idea from the iceberg-rust issue templates. Reporters say up front whether they can contribute the fix or feature, so reviewers don't have to ask in a follow-up comment.

What changes are included in this PR?

Adds an optional "Willingness to contribute" dropdown with three options to bug_report.yml and feature_request.yml. The wording is specific to bug fixes in the bug template and to features in the feature template.

What is the testing strategy for this PR?

Issue templates have no automated tests. Both files parse as YAML and the dropdown has the same shape as in the iceberg-rust and Comet templates.

Are there any user-facing changes?

New issues filed from the bug report and feature request forms get one extra optional dropdown. There are no API changes.

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Oct 7, 2026
@comphead
comphead requested review from alamb and timsaucer October 7, 2026 17:37

@asolimando asolimando left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the provided options and the wording used makes sense. I think it will be beneficial to move away from the take mechanism

@codecov-commenter

codecov-commenter commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.74%. Comparing base (1c43063) to head (2955918).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26120      +/-   ##
==========================================
+ Coverage   82.73%   82.74%   +0.01%     
==========================================
  Files        1147     1147              
  Lines      449389   449756     +367     
  Branches   449389   449756     +367     
==========================================
+ Hits       371788   372157     +369     
+ Misses      54943    54925      -18     
- Partials    22658    22674      +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2010YOUY01 2010YOUY01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I agree this would be helpful.

To other reviewers, you can preview by try opening an issue in comet: https://github.com/apache/datafusion-comet/issues

I also suggest we can mention the contributions should follow AI policy

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated
The Apache DataFusion community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Apache DataFusion codebase?
options:
- I can contribute a fix for this bug independently
- I would be willing to contribute a fix for this bug with guidance from the DataFusion community

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get this point, does that mean "I'm willing to contribute, but there are something I'm uncertain (described in issue), would open a PR after someone answer it"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use the phrase "plan" instead of "am willing"?

Perhaps something like:

I plan contribute a fix for this bug independently
I would like contribute a fix for this bug, but request guidance from the DataFusion community
I cannot contribute a fix for this bug at this time

@alamb

alamb commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

LGTM, the provided options and the wording used makes sense. I think it will be beneficial to move away from the take mechanism

Should we also plan to remove the take action (and its documentation)?

@alamb

alamb commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@comphead
comphead enabled auto-merge October 8, 2026 15:34
@comphead
comphead added this pull request to the merge queue Oct 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2026
@comphead
comphead added this pull request to the merge queue Oct 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2026
@comphead
comphead added this pull request to the merge queue Oct 8, 2026
Merged via the queue into apache:main with commit 409e3b8 Oct 8, 2026
42 checks passed
@comphead
comphead deleted the issue-template-willingness-to-contribute branch October 8, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion v56.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants