Skip to content

CLIENT-5039 Fix ListExp.appendItems with a Map element throws PARAMETER_ERROR #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirzakaracic wants to merge 4 commits into
base: stage-jdk8
Choose a base branch
from
Open

CLIENT-5039 Fix ListExp.appendItems with a Map element throws PARAMETER_ERROR #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2a022e
CLIENT-5039 Canonicalize unordered map expression value literals so s…
mirzakaracic Jul 7, 2026
8e144d8
CLIENT-5039 Skip map canonicalization during the size-estimate pass.
mirzakaracic Jul 7, 2026
82c5948
CLIENT-5039 Adapt canonical map key packing to the jdk8 single-pass P…
mirzakaracic Jul 7, 2026
5236bf2
CLIENT-5039 Restore Packer.createBuffer/getBuffer removed by mistake …
mirzakaracic Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions client/src/com/aerospike/client/exp/Exp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,9 +1723,13 @@ private ListVal(List<?> list) {
public void pack(Packer packer) {
// List values need an extra array and QUOTED in order to distinguish
// between a multiple argument array call and a local list.
// Value literals must be in canonical form (AER-6930): unordered maps
// at any depth are packed with keys sorted in server msgpack order.
packer.sortMaps(true);
packer.packArrayBegin(2);
packer.packInt(QUOTED);
packer.packList(list);
packer.sortMaps(false);
}
}

Expand All @@ -1738,7 +1742,11 @@ private MapVal(Map<?,?> map) {

@Override
public void pack(Packer packer) {
// Value literals must be in canonical form (AER-6930): unordered maps
// at any depth are packed with keys sorted in server msgpack order.
packer.sortMaps(true);
packer.packMap(map);
packer.sortMaps(false);
}
}

Expand Down
Loading
Loading