CLIENT-5039 Fix ListExp.appendItems with a Map element throws PARAMETER_ERROR#622
Open
mirzakaracic wants to merge 4 commits into
Open
CLIENT-5039 Fix ListExp.appendItems with a Map element throws PARAMETER_ERROR#622mirzakaracic wants to merge 4 commits into
mirzakaracic wants to merge 4 commits into
Conversation
…ervers with AER-6930 (8.1.2.3+) accept them. Server change AER-6930 validates list/map value literals in filter expressions by re-canonicalizing them and requiring byte-identical input. Canonical form packs map keys sorted in msgpack_cmp order with the order flag header preserved, so unordered multi-key maps packed in HashMap iteration order were rejected with PARAMETER_ERROR. Exp list/map value literals now pack unordered maps at any depth with entries sorted by key in the server's canonical msgpack order, without adding an order flag header. Non-expression packing paths (record writes, CDT operation arguments) are unchanged.
Packed map size is independent of entry order, so the estimate pass uses the plain packMap body. Key serialization, sorting and the duplicate-key check now run once per map literal instead of twice, and the estimate pass allocates nothing. Also reuse the two msgpack comparator instances across the sort instead of allocating two per comparison.
…acker. The jdk8 Packer has no size-estimate pass: the constructor takes the shared thread-local buffer and packs in a single pass, growing through resize()/toByteArray(). Pack canonical map keys through private-buffer packers instead of the estimate/createBuffer/write cycle, which would have clobbered the outer packer's thread-local buffer, and drop the jdk21-only estimate-pass (buffer != null) guards.
…in the jdk8 adaptation. They predate the port and are used by the top-level estimate-then-write packing in Exp, CdtExp and CdtOperation.
Test Results (gnu / 8.1.1.0_1)449 tests 393 ✅ 43s ⏱️ Results for commit 5236bf2. |
Test Results (bouncycastle / 8.1.0.3_2)449 tests 310 ✅ 42s ⏱️ For more details on these errors, see this check. Results for commit 5236bf2. |
Test Results (gnu / 8.1.0.3_2)449 tests 310 ✅ 42s ⏱️ For more details on these errors, see this check. Results for commit 5236bf2. |
Test Results (bouncycastle / 8.1.1.0_1)449 tests 393 ✅ 42s ⏱️ Results for commit 5236bf2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.