feat(akamai-client): OAE rule-tree helpers + updateRuleTree dryRun

[ABHA61]

What

Adds tree-inspection helpers + a dryRun option to @adobe/spacecat-shared-akamai-client, used by the LLM Optimizer "Optimize at Edge" (BYOCDN) Akamai onboarding in spacecat-api-service.

• defaultRuleHasCaching(ruleTree) — whether the property's default rule already has a Caching behavior. Cache ID Modification requires a Caching behavior in scope; the OAE rule must not add its own when the default provides it (that would override the property's HTML no-store and make the optimized path cacheable — serving stale/passthrough content to AI bots).
• getDefaultOriginSsl(ruleTree) — the default rule's origin SSL verification settings, for mirroring onto the OAE origin and gating onboarding on CUSTOM ("Choose Your Own") verification.
• updateRuleTree(..., { dryRun }) — validate a full-tree PUT without persisting (PAPI still requires an editable version).

Why

The api-service onboarding uses a full-tree PUT and needs to (a) validate before deploy (dryRun), (b) decide whether to add a Caching behavior, and (c) enforce a CUSTOM-default-origin scope gate. These are generic PAPI rule-tree concerns, so they belong in the shared client.

Design

High-Level Design: Optimize at Edge — Akamai BYOCDN Automation (HLD)

Testing

Unit tests for both helpers (present / absent / malformed / origin-without-options trees) and the dry-run query; npm test green, lint clean, 100% coverage.

🤖 Generated with Claude Code

[github-actions]

This PR will trigger a minor release when merged.

[MysticatBot]

Hey @ABHA61,

Verdict: Request changes - TypeScript declaration is out of sync with the implementation.
Complexity: MEDIUM - medium diff, single package.
Changes: Adds two rule-tree inspection helpers and a dryRun option to updateRuleTree in the Akamai client (4 files).

Must fix before merge

1. [Important] TypeScript declaration missing options parameter on updateRuleTree - packages/spacecat-shared-akamai-client/src/index.d.ts (details inline)
2. [Important] Missing test for getDefaultOriginSsl branch where origin behavior exists without options key - packages/spacecat-shared-akamai-client/test/akamai-client.test.js (details inline)

Non-blocking (2): minor issues and suggestions

• nit: No test pinning the negative case (dryRun param absent from query when options.dryRun is falsy) - test/akamai-client.test.js. The existing tests implicitly cover it via nock query matching, but an explicit case documents the contract.
• suggestion: Add a test for getDefaultOriginSsl with partial options (e.g. only verificationMode set) to document that the returned object carries undefined values for missing keys rather than omitting them - test/akamai-client.test.js.

---

_{Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 12m 31s | Cost: $5.61 | Commit: 98e7a6bd5ccc75b342b3b74a49da07ab67d406cd
If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[MysticatBot]

issue (blocking): The updateRuleTree method signature in this file was not updated to include the new options parameter. The JS implementation now accepts 7 arguments (propertyId, version, contractId, groupId, ruleTree, ruleFormat, options = {}), but the .d.ts still declares 6. TypeScript consumers will get a compile error when passing { dryRun: true }.

The sibling method patchRuleTree already shows the correct pattern. Fix:

updateRuleTree(
  propertyId: string,
  version: number,
  contractId: string,
  groupId: string,
  ruleTree: object,
  ruleFormat?: string,
  options?: { dryRun?: boolean },
): Promise<object>;

[MysticatBot]

issue (blocking): The implementation guards on !origin || !origin.options (two distinct branches), but the tests only cover the !origin case (behaviors: [{ name: 'caching' }]) and the fully-absent-tree case (null). A real PAPI response could return { name: 'origin' } with no options key - that branch is untested.

Given the project enforces 97% branch coverage, add:

it('returns null when origin behavior exists but has no options', () => {
  expect(getDefaultOriginSsl({ rules: { behaviors: [{ name: 'origin' }] } })).to.be.null;
});

[ABHA61]

Follow-up: completed the updateRuleTree type declaration and added a getDefaultOriginSsl test. Tests green, lint clean.

[MysticatBot]

Hey @ABHA61,

⚠ Degraded review - no spec document was found for this change (searched the PR links, the touched repos' docs, the architecture/guidelines docs, and linked Jira). This review covers code-level quality but could not validate the change against an agreed design, so confidence is reduced. Add a spec link (PR template section 4) and re-request review for a full-confidence pass.

Verdict: Approve - prior findings addressed, no new concerns across code quality, architecture, security, conventions, or testing.
Complexity: MEDIUM - medium diff, single package.
Changes: Adds two rule-tree inspection helpers (defaultRuleHasCaching, getDefaultOriginSsl) and a dryRun option to updateRuleTree in the Akamai client (4 files).

Previously flagged, now resolved

• TypeScript declaration for updateRuleTree now includes the options parameter
• Test added for getDefaultOriginSsl when origin behavior exists without options key

---

_{Skill: pr-review | Model: us.anthropic.claude-opus-4-6-v1[1m] | Duration: 0m 3s | Cost: $3.86 | Commit: 97971d13c2276e4b3ad59801d6e00521ca9443b8
If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[solaris007]

🎉 This PR is included in version @adobe/spacecat-shared-akamai-client-v1.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀