feat(akamai-client): OAE rule-tree helpers + updateRuleTree dryRun#1826
Closed
ABHA61 wants to merge 3 commits into
Closed
feat(akamai-client): OAE rule-tree helpers + updateRuleTree dryRun#1826ABHA61 wants to merge 3 commits into
ABHA61 wants to merge 3 commits into
Conversation
Support the LLM Optimizer "Optimize at Edge" Akamai onboarding in spacecat-api-service:
- defaultRuleHasCaching(ruleTree): whether the property's default rule already has a
Caching behavior. Cache ID Modification requires one in scope; the OAE rule must NOT
add its own when the default provides it (that would override the property's HTML
no-store and make the optimized path cacheable).
- getDefaultOriginSsl(ruleTree): the default rule's origin SSL verification settings,
for mirroring onto the OAE origin and gating onboarding on CUSTOM verification.
- updateRuleTree now accepts an optional { dryRun } to validate a full-tree PUT without
persisting (PAPI still requires an editable version).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds a test asserting dryRun=true is appended to the query when options.dryRun is set, restoring 100% line coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…hout-options
- index.d.ts: add the options?: { dryRun?: boolean } parameter to updateRuleTree
so typed consumers can pass { dryRun: true } (was 6 args, impl accepts 7).
- test: cover getDefaultOriginSsl when the origin behavior has no options key
(distinct from no origin) for the 100% branch gate.
Addresses MysticatBot/Codex review.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Closing — keeping the original PR #1825 for review instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash-collapses the OAE onboarding work onto a fresh
feat/akamai-oae-automationbranch (cut frommain) so the review PR (feat/akamai-oae-automation→main) shows a single commit for senior review.Squash-merge this PR — that puts one commit on
feat/akamai-oae-automation. Full context lives in the automation → main review PR.