Repository navigation
Refactor coordinate system import (PR 1) - #1508
Open
MaximeBICMTL wants to merge 2 commits into
Open
MaximeBICMTL wants to merge 2 commits into
MaximeBICMTL wants to merge 2 commits into
Conversation
github-actions
Bot
added
Language: Python
MaximeBICMTL
force-pushed
the
coord-system-import-refactor
branch
from
October 5, 2026 03:55
c38f863 to
0849ddd
Compare
MaximeBICMTL
force-pushed
the
coord-system-import-refactor
branch
from
October 5, 2026 03:56
0849ddd to
90f8b95
Compare
This was referenced Oct 5, 2026
MaximeBICMTL
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors coordinate import refactor
Commit 1
Extend our unit test system to allow to have per-module unit tests, which allows us to have nice unit tests in the second commit!
Commit 2
Migrate coordinate system import from the untyped
Physiological(removed relevant code) andPhysiologicalCoordSystem(added deprecation) files to new typed files, properly split into ORM queries, LORIS helpers, BIDS helpers, and BIDS import script.I tried to stay close to the existing architecture, I am still not sure about if our database schema and the MEG integration are good, but both are out-of-scope for this PR.