Repository navigation
DIE physiological.py DIE (electrodes import refactor) (PR 2) - #1509
Open
MaximeBICMTL wants to merge 3 commits into
Open
MaximeBICMTL wants to merge 3 commits into
MaximeBICMTL wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1508 (diff)
Description
Refactor
electrodes.tsvimport to use the ORM database abstraction, good layering inloris_bids_utils,loris_corelib,loris_bids_importer, and typed code.A notable design change is that the previous code proceeded in this order:
But this design is not ideal, because if step 2 fails, then electrodes are left without link to their coordinate system (and thus their acquisition file given the current table architecture).
The new import order is:
This order is simpler, more error-resilient, and easier to extend to other modalities like MEG (which is currently not integrated with coordinate systems yet).
This PR notably finally gets rid of
physiological.py, which is a very good thing that we should celebrate. The table design is still horrendous but that can now be more easily improved on after this PR.