Skip to content

Formatting: Convert multiplication symbol to 'x' in title slugs #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshupathak95 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+36 −1
Open

Formatting: Convert multiplication symbol to 'x' in title slugs #10659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ff76b
Formatting: Replace multiplication symbol with 'x' in slugs
himanshupathak95 Dec 23, 2025
5786eb4
Tests: Test multiplication sign handling in sanitize_title_with_dashes
himanshupathak95 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/wp-includes/formatting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,6 +2284,9 @@ function sanitize_title_with_dashes( $title, $raw_title = '', $context = 'displa
// Restore octets.
$title = preg_replace( '|---([a-fA-F0-9][a-fA-F0-9])---|', '%$1', $title );

// Convert multiplication sign and times entities to 'x'.
$title = str_replace( array( '×', '×', '×' ), 'x', $title );
Comment on lines +2287 to +2288
Copy link
Member

@westonruter westonruter Dec 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be added here as opposed to being added right after the existing:

wordpress-develop/src/wp-includes/formatting.php

Lines 2386 to 2387 in 5786eb4

// Convert &times to 'x'.
$title = str_replace( '%c3%97', 'x', $title );


if ( wp_is_valid_utf8( $title ) ) {
if ( function_exists( 'mb_strtolower' ) ) {
$title = mb_strtolower( $title, 'UTF-8' );
Expand Down
34 changes: 33 additions & 1 deletion tests/phpunit/tests/formatting/sanitizeTitleWithDashes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,39 @@ public function test_replaces_forward_slash() {
* @ticket 19820
*/
public function test_replaces_multiply_sign() {
$this->assertSame( '6x7-is-42', sanitize_title_with_dashes( '6×7 is 42', '', 'save' ) );
$this->assertSame( '6x7-is-42', sanitize_title_with_dashes( '6×7 is 42', '', 'save' ), 'Multiplication sign (×) should be replaced with letter x' );
}

/**
* @ticket 64284
*/
public function test_replaces_multiply_sign_with_spaces() {
$this->assertSame( 'iphone-12-x-256gb', sanitize_title_with_dashes( 'iPhone 12 × 256GB', '', 'save' ), 'Product title with multiplication sign and spaces should convert × to x' );
$this->assertSame( 'screen-1920-x-1080', sanitize_title_with_dashes( 'Screen 1920 × 1080', '', 'save' ), 'Screen dimensions with multiplication sign should convert × to x' );
}

/**
* @ticket 64284
*/
public function test_replaces_times_html_entity() {
$this->assertSame( '6x7-is-42', sanitize_title_with_dashes( '6×7 is 42', '', 'save' ), 'HTML entity × should be replaced with letter x' );
$this->assertSame( 'product-5x10', sanitize_title_with_dashes( 'Product 5×10', '', 'save' ), 'HTML entity × without spaces should be replaced with letter x' );
}

/**
* @ticket 64284
*/
public function test_replaces_times_numeric_entity() {
$this->assertSame( '3x4-equals-12', sanitize_title_with_dashes( '3×4 equals 12', '', 'save' ), 'Numeric HTML entity × should be replaced with letter x' );
}

/**
* @ticket 64284
*/
public function test_replaces_multiply_sign_in_display_context() {
// Should work in display context too, not just 'save'.
$this->assertSame( '6x7', sanitize_title_with_dashes( '6×7', '', 'display' ), 'Multiplication sign should be replaced with x in display context' );
$this->assertSame( 'testx', sanitize_title_with_dashes( 'test×', '' ), 'Multiplication sign should be replaced with x when context is not specified' );
}

/**
Expand Down
Loading