Skip to content

Conversation

@himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Dec 23, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/64284

This PR ensures the multiplication symbol (×) and its HTML entities are consistently replaced with the letter "x" when sanitizing titles for slugs.

Users sometimes accidentally type × (U+00D7, Multiplication Sign) instead of x (U+0078, Latin Small Letter X) in post titles. The existing code only replaced the URL-encoded form (%c3%97) after encoding, which didn't handle the character consistently in all cases.

This PR adds replacement of the multiplication character and its entities before URL encoding occurs:

  • Direct character: ×
  • HTML entity: ×
  • Numeric entity: ×

The existing replacement of %c3%97 (line 2387) is retained as a fallback for already-encoded content.

Examples

Input Output
iPhone 12 × 256GB iphone-12-x-256gb
Screen 1920 × 1080 screen-1920-x-1080
6×7 is 42 6x7-is-42
Product 5×10 product-5x10

@himanshupathak95 himanshupathak95 changed the title Fix/64284 Formatting: Convert multiplication symbol to 'x' in title slugs Dec 23, 2025
@himanshupathak95 himanshupathak95 marked this pull request as ready for review December 23, 2025 14:24
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +2287 to +2288
// Convert multiplication sign and times entities to 'x'.
$title = str_replace( array( '×', '×', '×' ), 'x', $title );
Copy link
Member

@westonruter westonruter Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be added here as opposed to being added right after the existing:

// Convert &times to 'x'.
$title = str_replace( '%c3%97', 'x', $title );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants