feat(screenshot): Add threaded JPEG/PNG screenshots without game stalls by bobtista · Pull Request #1785 · TheSuperHackers/GeneralsGameCode

bobtista · 2025-11-03T03:24:45Z

Summary

Replaces the old BMP screenshot with compressed JPEG screenshots that don't stall the game, and adds PNG support.

Closes #1555
Closes #106 ... sort of

Adds a new screenshot function using the stb_image_write library with background threading:

F12 - Compressed JPEG screenshot (no stalling, ~600KB files)
Ctrl+F12 - Lossless PNG screenshot

Notes

stb_image-write is public domain licensed, single-header, zero compilation needed
Captures frame buffer on main thread (~1-2ms)
Spawns detached thread for JPEG/PNG compression and disk I/O
JPEG quality configurable via Options.ini (default 80)
Works for both Generals and Zero Hour

Testing

Screenshots save correctly with F12 (jpg) and Ctrl+F12 (png)
No game stalling during screenshot
Files appear in correct directory with sequential numbering

Stubbjax · 2025-11-03T06:48:50Z

Some initial thoughts:

Keep variants of the same function to a single hotkey; instead toggle image format via a new setting in Options.ini
Apply image compression / quality via a new setting in Options.ini
Can we consolidate this logic in core instead of repeating the implementation twice?

xezon · 2025-11-03T06:58:11Z

Agree with Stubbjax.

JPG 90 is big file. Better make it default 80.

Replace BMP screenshot with PNG screenshot. PNG is lossless compressed and always better than BMP.

Make F12 take JPG 80 screenshot. Make CTRL+F12 take PNG screenshot. Make JPG Quality adjustable.

Remove the old BMP code(s) and only use the new code for screenshot.

xezon · 2025-11-03T07:00:32Z

Regarding Github formatting:

When you write

Addresses #1555

Then it will not close this report when this is merged.

Please read up on it here:
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#closing-multiple-issues

bobtista · 2025-11-03T16:26:53Z

Some initial thoughts:

Keep variants of the same function to a single hotkey; instead toggle image format via a new setting in Options.ini

Apply image compression / quality via a new setting in Options.ini

Can we consolidate this logic in core instead of repeating the implementation twice?

RE moving logic to core, I moved what I could to core - but there are a lot more files that need to be moved to core before this can be moved there eg WWVegas/WW3D2/*

Generals/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp

Generals/Code/GameEngineDevice/Include/W3DDevice/GameClient/W3DDisplay.h

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DScreenshot.cpp

Generals/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp

cmake/stb.cmake

xezon · 2025-11-22T17:34:07Z

Needs rebase.

bobtista · 2025-11-22T18:22:35Z

Needs rebase.

Done

Core/GameEngineDevice/Include/W3DDevice/GameClient/W3DScreenshot.h

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/stb_image_write_impl.cpp

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DScreenshot.cpp

Generals/Code/GameEngine/Include/Common/MessageStream.h

Generals/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp

GeneralsMD/Code/GameEngine/Include/Common/MessageStream.h

Generals/Code/GameEngine/Source/GameClient/MessageStream/CommandXlat.cpp

Skyaero42

Looks good to me

greptile-apps

_{33 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

cmake/stb.cmake

greptile-apps

_{33 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-24T18:15:12Z

cmake/stb.cmake

@@ -0,0 +1,19 @@
+# TheSuperHackers @bobtista 02/11/2025


Date in comment (02/11/2025) is from the past; should be updated to 2026

Suggested change

# TheSuperHackers @bobtista 02/11/2025

# TheSuperHackers @bobtista 02/24/2026

Context Used: Rule from dashboard - What: Flag newly created code comments that reference dates prior to the current year (2026).

Why: ... (source)

Prompt To Fix With AI

This is a comment left during a code review. Path: cmake/stb.cmake Line: 1 Comment: Date in comment (02/11/2025) is from the past; should be updated to 2026 ```suggestion # TheSuperHackers @bobtista 02/24/2026 ``` **Context Used:** Rule from `dashboard` - What: Flag newly created code comments that reference dates prior to the current year (2026). Why: ... ([source](https://app.greptile.com/review/custom-context?memory=fd72a556-4fd8-4db4-8b08-8e51516a64ad)) How can I resolve this? If you propose a fix, please make it concise.

Add takeScreenShotCompressed() to Display interface

Implement threaded JPEG screenshot for Generals Link stb library to GameEngineDevice targets Remove excessive comments from screenshot implementation

Add shared screenshot implementation in Core

Move W3DScreenshot implementation to game-specific directories Fix include order for VC6 precompiled headers Remove default parameter from function definition Move STB implementation to separate file to avoid PCH issues Include screenshot implementation directly in W3DDisplay.cpp to avoid PCH issues Use Windows constants and switch statement in screenshot code Use vcpkg for stb dependency with FetchContent fallback

… rebase

…rmat enum

…ince it's included in W3DDisplay.cpp

Move stb_image_write_impl.cpp from game-specific directories to Core since it's identical between Generals and GeneralsMD and contains only STB library implementation code with no game-specific logic.

…o nullptr, strcpy to strlcpy, fix thread leak

…on unit instead of #including it

…mpty CMake blocks

…nerals

…ly created

Caball009 · 2026-02-26T18:41:51Z

Core/GameEngine/Source/Common/OptionPreferences.cpp

+	Int quality = atoi(it->second.str());
+	if (quality < 1) quality = 1;
+	if (quality > 100) quality = 100;


bobtista force-pushed the bobtista/compressed-screenshot-f11 branch 4 times, most recently from 20a3df1 to 37bd840 Compare November 3, 2025 04:32

xezon added Enhancement Is new feature or request Major Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Nov 3, 2025

L3-M added this to the GenTool features replication milestone Nov 3, 2025

L3-M added the Input label Nov 3, 2025

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch 3 times, most recently from 3535e1e to efc773f Compare November 3, 2025 17:45

Skyaero42 requested changes Nov 3, 2025

View reviewed changes

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch 2 times, most recently from 977a6dc to f8162f3 Compare November 3, 2025 23:07

OmniBlade reviewed Nov 5, 2025

View reviewed changes

cmake/stb.cmake Outdated Show resolved Hide resolved

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch from d7e8a8d to d197bdd Compare November 5, 2025 18:04

L3-M mentioned this pull request Nov 6, 2025

Replicate relevant GenTool fixes and improvements #850

Open

34 tasks

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch from d197bdd to 9669966 Compare November 11, 2025 21:27

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch from 9669966 to 4897b0b Compare November 22, 2025 18:10

Skyaero42 requested changes Nov 22, 2025

View reviewed changes

Skyaero42 previously approved these changes Nov 22, 2025

View reviewed changes

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch from 9c99306 to de35e57 Compare December 3, 2025 16:48

greptile-apps bot reviewed Feb 24, 2026

View reviewed changes

cmake/stb.cmake Show resolved Hide resolved

greptile-apps bot reviewed Feb 24, 2026

View reviewed changes

bobtista added 26 commits February 24, 2026 19:00

Add stb library dependency via FetchContent

1e7ee6a

Add MSG_META_TAKE_SCREENSHOT_COMPRESSED message and F11 keybinding

3126d6f

Add takeScreenShotCompressed() to Display interface

Implement threaded JPEG screenshot for GeneralsMD

ab2d333

Implement threaded JPEG screenshot for Generals Link stb library to GameEngineDevice targets Remove excessive comments from screenshot implementation

Use Win32 CreateThread for VC6 compatibility and add GUIEditDisplay stub

53fd0d5

Move screenshot logic to Core to eliminate code duplication

00ff872

Add shared screenshot implementation in Core

Change F12 to JPEG and add CTRL+F12 for PNG screenshots

734385f

Remove old BMP screenshot code

285c3e4

Remove trailing whitespace from empty lines

148b260

Fix copyright headers: Change Electronic Arts Inc. to TheSuperHackers

c509412

Add file headers to W3DScreenshot.cpp files

de4929c

Rename MSG_META_TAKE_SCREENSHOT_JPEG to MSG_META_TAKE_SCREENSHOT_PNG

269af80

fix(screenshot): Fix W3DScreenshot.cpp references in CMakeLists after…

ef67a08

… rebase

fix(screenshot): Add missing W3DScreenshot.h include for ScreenshotFo…

82f858a

…rmat enum

fix(screenshot): Use full include path for W3DScreenshot.h from Core

a888657

fix(screenshot): Remove W3DScreenshot.cpp from separate compilation s…

d1ed4f1

…ince it's included in W3DDisplay.cpp

refactor(screenshot): Consolidate stb_image_write_impl.cpp to Core

ea0abcc

Move stb_image_write_impl.cpp from game-specific directories to Core since it's identical between Generals and GeneralsMD and contains only STB library implementation code with no game-specific logic.

docs(unify): Document stb_image_write_impl.cpp unification in script

7d700d7

fix(screenshot): Restore DESTROY_MESSAGE, fix quality default, NULL t…

a4de747

…o nullptr, strcpy to strlcpy, fix thread leak

fix(screenshot): Replicate screenshot fixes to Generals

ce03627

refactor(screenshot): Compile W3DScreenshot.cpp as separate translati…

e62f2c2

…on unit instead of #including it

refactor(screenshot): Replicate separate compilation fix to Generals

30b405d

fix(screenshot): Initialize m_jpegQuality in constructor and remove e…

b50793c

…mpty CMake blocks

fix(screenshot): Replicate m_jpegQuality init and CMake cleanup to Ge…

c339280

…nerals

Only show screen capture message when screenshot thread is successful…

20a9eb2

…ly created

Remove dead CreateBMPFile function replaced by compressed screenshot

b709c32

bobtista force-pushed the bobtista/compressed-screenshot-f11 branch from 8779ab1 to b709c32 Compare February 25, 2026 00:03

Caball009 reviewed Feb 26, 2026

View reviewed changes

	# TheSuperHackers @bobtista 02/11/2025
	# TheSuperHackers @bobtista 02/24/2026

Conversation

bobtista commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Testing

Uh oh!

Stubbjax commented Nov 3, 2025

Uh oh!

xezon commented Nov 3, 2025

Uh oh!

xezon commented Nov 3, 2025

Uh oh!

bobtista commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xezon commented Nov 22, 2025

Uh oh!

bobtista commented Nov 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Skyaero42 left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Caball009 Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bobtista commented Nov 3, 2025 •

edited

Loading