Skip to content

fix(db): preserve ordering invalidations during repair retirement #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyleAMathews wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(db): preserve ordering invalidations during repair retirement #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e5b54a
Preserve ordered repair debt through acquisition retirement
Oct 29, 2026
6260f52
Merge remote-tracking branch 'origin/main' into codex/misfits-repair-…
Oct 29, 2026
2db3eeb
Document ordered retirement repair release
Oct 29, 2026
d10bf57
Reference executable retirement evidence in coverage map
Oct 29, 2026
5e3cb22
test(db): calibrate retirement through minified-safe observations
Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/preserve-reentrant-ordering-repair.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/db': patch
---

Preserve ordering invalidations raised while an ordered repair retires its previous acquisitions. Revalidate the affected source prefix before publishing the repaired window.
4 changes: 2 additions & 2 deletions docs/contributing/oracle-coverage.md
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion packages/db/src/query/live/ordered-source-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,13 @@ export class OrderedSourceLoader {
if (!this.active || !hasSupersededAcquisition) {
this.cancelRepairRetry()
this.repairRetries = 0
this.moveWork({ kind: `idle` }, [`repair`], `none`)
// Retirement can deliver a newer invalidation. This chain pays only
// its own epoch; the next pass must still repair that newer order.
this.moveWork(
{ kind: `idle` },
[`repair`],
this.repairNeedsReplacement() ? this.debt : `none`,
)
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions packages/db/tests/oracle-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ const staticOracleProperties = [
`query-db.refetch-ordered-prefix`,
`ordered-loader.request-authority`,
`ordered-loader.unproven-report`,
`ordered-loader.replay-continuation`,
`ordered-loader.retirement-invalidation`,
`ordered-loader.retirement-receiver`,
`replay.ordered-window-faults`,
`replay.ordered-failed-replay`,
`replay.ordered-preload-recovery`,
Expand Down
2 changes: 1 addition & 1 deletion packages/db/tests/oracle-replay-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ const ownerGroups: ReadonlyArray<
[
`db/tests/query/ordered-source-loader-state-oracle.test.ts`,
`ordered-loader`,
`request-authority unproven-report`,
`request-authority unproven-report replay-continuation retirement-invalidation retirement-receiver`,
],
[
`db-sqlite-persistence-core/tests/sqlite-core-adapter-cli-runtime.test.ts`,
Expand Down
Loading
Loading