Repository navigation
fix(chrome): place toolbar sections and view switchers where the HIG puts them - #3851
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UIDesignRequiresCompatibility. Every surface follows the HIG instead.scripts/probes/check-toolbar-autosave-reorder.sh).PaneTabBar: a centred tab row, regular with the tabs role on macOS 27, over content that runs edge to edge. Structure, Create Table, Create Table forms, User Type, Compare detail. No bordered tab view, which boxed and inset the grids.viewSwitcherStyle(), small with the tabs role on macOS 27: results view mode, Query Plan, Version History, JSON results, the cell viewers, the trailing pane header, the geometry field, Data File sheets, Users & Roles detail.ToolbarSymbols, and the Structure section bar usessafeAreaBar.QueryPlanResultUITests,DataFileWindowUITestsand theshowStructurehelper. On macOS 27 XCUITest reports a tabs-role control as a tab group ofTabelements (read from the CI element tree), so segments go through a newswitcherSegment(_:in:).Test plan
BindingCommittingGridEditTests,PrivilegeScopeOutlineSelectionTests,ViewSwitcherStyleTests,SidebarScopeControlTests.tabsRoleOnMacOS27,ToolbarSymbolsTestssort cases.DataBrowserViewModelTestsandConnectionListRowModelTests, 49 passing; lint and l10n clean.#availablefallbacks, covered by tests, not on screen.Fixes #3844