fix: anchor mention popover at composer top-leading#1086
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mention popover anchor was
.point(.top)(top-center of composer), so the popover floated centered above the composer regardless of where the@character was actually typed. Since the user types@at the leftmost edge of the text input, the popover should hang over that edge instead of the center.Change to
.point(.topLeading). Combined witharrowEdge: .bottom, the popover now anchors at the top-left corner of the composer with its arrow tip at that point, hanging up-and-right from there.This is the closest pure-SwiftUI approximation of caret-anchored autocomplete (Apple Mail address autofill, VS Code mention dropdown). True caret-precise anchoring requires NSTextView selection rect math, which would reintroduce the TextKit 1 dependency we dropped in #1076.
Test plan
@. The mention popover appears anchored to the top-left of the composer.