revert: AI inline assistant for SQL editor (PR F)#1088
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the inline SQL assistant from #1084 — too much surface area for an experimental feature. ~750 LOC of new code:
InlineAssistantSession,InlineAssistantPresenter,InlineAssistantOverlayController,InlineAssistantPromptView,AIEditorContextMenu, prompt templates, plus borderless NSPanel + NSEvent localKeyDown monitor wiring throughSQLEditorCoordinator.The chat panel + per-connection rules + per-mode tool gating (PRs A, B, C, D, G) cover the core AI assistance path. Inline rewrite-in-place adds a second editor surface, a second streaming pipeline, and a custom panel chrome — return on complexity is not yet proven.
What this PR does
InlineAssistant*files, the editor coordinator hooks, theAIEditorContextMenuwiring, and theEdit > Rewrite with AI…menu.nonisolatedmodifier onChatToolRegistry.isToolAllowed(name:in:)— that part of fix: inline assistant + tool registry compile errors #1085 was for PR D's tool gating (still in main) and is unrelated to inline assistant. Without it,AIChatViewModel.runToolUse(nonisolated static) cannot callisToolAllowed.What stays in main
Test plan
InlineAssistant*references remain.Rewrite with AI...item.xcodebuild test -only-testing:TableProTests/ChatToolRegistryModeTestsstill passes (verifiesisToolAllowedreachable from nonisolated context).