Github actions: use matrix to run combinations of ubuntu/macos/mpich/openmpi #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/main.yml
Outdated
Comment on lines
219
to
222
| rm -rf ${GITHUB_WORKSPACE}/pnetcdf_output | ||
| rm -rf ${GITHUB_WORKSPACE}/pnetcdf_install | ||
| rm -rf ${GITHUB_WORKSPACE}/inst | ||
| rm -rf ${GITHUB_WORKSPACE}/MPI |
Contributor
There was a problem hiding this comment.
This isn't needed since GitHub Actions will delete the entire VM anyway.
Comment on lines
+37
to
+42
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| mpi_vendor: [ MPICH, OpenMPI ] | ||
| fstype: [ ufs, mimic_lustre ] |
Contributor
There was a problem hiding this comment.
Should ADIOS be added to this matrix?
.github/workflows/main.yml
Outdated
| @@ -0,0 +1,223 @@ | |||
| name: Combinations of Ubuntu/MacOSX and MPICH/OpenMPI | |||
Contributor
There was a problem hiding this comment.
This gets prefixed to the job name, and is thus pretty long. As a result, I've seen a bunch of projects just call this "CI".
Member
Author
|
Thanks for the suggestions. ADIOS and NetCDF4 will go to a separate workflow in PR #217, as the current support for these two features are limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All existing gihub action CI yaml files can be merged into one using the matrix strategy feature, as they share many configure and make commands.