-
Notifications
You must be signed in to change notification settings - Fork 32
Move CI to jobs in single workflow #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Move CI to jobs in single workflow #206
Conversation
|
Looks like using a matrix is a good way to go. Could you revise this PR? |
53230e6 to
f3e8ae6
Compare
|
@wkliao I just updated this PR with the most recent CI changes. This PR simply copies and pastes everything as-is into a single workflow. This means that all the jobs now share the same workflow triggers and environment variable definitions. Since this is already such a large PR, my plan is to create a series of smaller follow-up PRs to gradually reduce the amount of duplication via a matrix. Let me know if you'd like me do anything differently! |
This commit moves CI from individual workflows to a series of jobs in a single workflow. This allows jobs to share the same triggers and environment variables. This can be further simplified in a future commit by using a matrix to share common installation and build logic between jobs.
f3e8ae6 to
a958b06
Compare
I wonder if this PR can be modified to use the matrix approach directly, i.e. by skipping the middle changes. |
|
FYI. PR #216 uses the matrix strategy. I think that is more concise. |
|
Closing in favor of #216. |
This commit moves CI from individual workflows to a series of jobs in a single workflow. This allows jobs to share the same triggers and environment variables. This can be further simplified in a future commit by using a matrix to share common installation and build logic between jobs.