Skip to content

input[type=range] fix on Chrome#1282

Closed
louismaximepiton wants to merge 5 commits into
mainfrom
main-lmp-progress-bar-fix
Closed

input[type=range] fix on Chrome#1282
louismaximepiton wants to merge 5 commits into
mainfrom
main-lmp-progress-bar-fix

Conversation

@louismaximepiton

@louismaximepiton louismaximepiton commented May 30, 2022

Copy link
Copy Markdown
Member

Fixes #1264

https://deploy-preview-1282--boosted.netlify.app/docs/5.2/forms/range/

It fixes the thumb display on Chrome and add an explaination to implement the runnable track on Chrome.

@netlify

netlify Bot commented May 30, 2022

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5e35a37
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6375f602aa7e920008acd411
😎 Deploy Preview https://deploy-preview-1282--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond

Copy link
Copy Markdown
Contributor

CodePen rendering isn't a bit weird with the black border when we click on the slider?

Peek 2022-05-31 07-30

@julien-deramond

Copy link
Copy Markdown
Contributor

Regarding the use of a CodePen I'm not against it atm but I'm afraid it would be complicated to maintain for each version.
In the documentation, we already have a "Progressive enhancement" warning callout, wouldn't be easier to maintain to explain the content of your CodePen directly in the documentation (even without showing the rendering)?

@louismaximepiton

Copy link
Copy Markdown
Member Author

Regarding the use of a CodePen I'm not against it atm but I'm afraid it would be complicated to maintain for each version. In the documentation, we already have a "Progressive enhancement" warning callout, wouldn't be easier to maintain to explain the content of your CodePen directly in the documentation (even without showing the rendering)?

You're right, during the write of the Codepen, I was asking myself on how to remember to update this Codepen, I'll implement your idea.

@julien-deramond julien-deramond added the 📖 documentation Improvements or additions to documentation label Jun 10, 2022
@julien-deramond

Copy link
Copy Markdown
Contributor

@MewenLeHo This PR can be interesting for you regarding the sliders prototypes you're developing.

@louismaximepiton louismaximepiton force-pushed the main-lmp-progress-bar-fix branch from 6659905 to 4ee804f Compare July 4, 2022 13:34
@louismaximepiton louismaximepiton force-pushed the main-lmp-progress-bar-fix branch from 4ee804f to e8ad134 Compare August 30, 2022 08:55
@ffoodd

ffoodd commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

FWIW this example could be lighter on the JS-side by using a CSS custom property, here's an example on CodePen.

@louismaximepiton

Copy link
Copy Markdown
Member Author

Hi @ffoodd,

Thanks for the comment, I tried to take the CodePen into account, it kindly dedupes the CSS code which is way better. Do you think it's worth to integrate the explanation in Bootstrap directly ?

@ffoodd

ffoodd commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

You may suggest it for sure, but I dont know if it'll be merged 🙂

@louismaximepiton

Copy link
Copy Markdown
Member Author

Let's wait for twbs/bootstrap#37499 !

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond

Copy link
Copy Markdown
Contributor

Closing it. Wait for twbs/bootstrap#37499. If accepted in Bootstrap it will be introduced in Boosted automatically. If not, we will recreate a PR here.

@louismaximepiton louismaximepiton deleted the main-lmp-progress-bar-fix branch February 23, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser bug 📖 documentation Improvements or additions to documentation fix ⚠️ on hold v5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Range slider: no progress bar

3 participants