fix(range): realign input range thumb margin on Webkit#1632
Merged
julien-deramond merged 2 commits intoNov 17, 2022
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
louismaximepiton
added a commit
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
|
Kudos, SonarCloud Quality Gate passed!
|
louismaximepiton
approved these changes
Nov 17, 2022
louismaximepiton
left a comment
louismaximepiton
left a comment
Member
There was a problem hiding this comment.
If you're fine with this implementation, let's go with this!
julien-deramond
deleted the
main-jd-fix-input-range-thumb-margin-on-chrome
branch
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes #1606
Description
Change the calculation to position the input range thumb on Webkit.
TBH I haven't checked on all browsers. Dear reviewer, could you help me doing that 🙏
Types of change
Live previews
Checklist
npm run lint)