Skip to content

cpu-o3: Reformat O3 source files - #1036

Open
happy-lx wants to merge 1 commit into
xs-devfrom
taoshuo/o3-code-style-cleanup
Open

happy-lx wants to merge 1 commit into
xs-devfrom
taoshuo/o3-code-style-cleanup

Conversation

@happy-lx

@happy-lx happy-lx commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Separate formatting-only O3 changes that were mixed into #1008, so PHAST behavior can be reviewed independently.

Scope

  • Reformat commit.cc, dyn_inst.hh, iew.cc, and mem_dep_unit.cc.
  • No PHAST or MDP behavior, configuration, statistics, or other functional changes are included.

Validation

  • git diff --check passes.
  • Each changed file has the same lexical token sequence as xs-dev; only whitespace, line wrapping, indentation, and comment spacing differ.

Extract whitespace-only changes from the PHAST development series.

Change-Id: Icd414e5ee5f3d70c39f35947316400b8dbe4f97b
@happy-lx
happy-lx requested a review from jueshiwenli as a code owner August 11, 2026 10:53
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@happy-lx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 78cf0d94-24dd-4ba9-a6f8-94700d04ae06

📥 Commits

Reviewing files that changed from the base of the PR and between 618ffb4 and f127297.

📒 Files selected for processing (4)
  • src/cpu/o3/commit.cc
  • src/cpu/o3/dyn_inst.hh
  • src/cpu/o3/iew.cc
  • src/cpu/o3/mem_dep_unit.cc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.2475 -
This PR 2.2475 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

@jueshiwenli

Copy link
Copy Markdown
Collaborator

非常好的feature使我醍醐灌顶

@jueshiwenli
jueshiwenli requested a review from weidingliu August 12, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants