Repository navigation
chore: gofmt cleanup — 16 files (rebased onto main) - #355
Conversation
|
Rebased onto main by felixfelix-bot (supersedes #341). Ready for c03rad0r review + merge. Gofmt cleanup — 16 files. Clean rebase, no conflicts. |
Amperstrand
left a comment
Amperstrand
left a comment
There was a problem hiding this comment.
Fidelity-verified: validator.go import regrouping (stdlib/third-party with blank line) present, 12 files formatted, CI green.
One note: 3 files remain gofmt-dirty after this PR — , , (verified on this PR's tree with gofmt -l). They arrived in the merge wave after this branch was cut. Our orphaned rebuild 9a42098 covered all 14; happy to send a tiny follow-up PR finishing the remaining 3 once #353 (which also touches config_schema.go) and this land — say the word.
Amperstrand
left a comment
Amperstrand
left a comment
There was a problem hiding this comment.
Fidelity-verified: validator.go import regrouping (stdlib/third-party with blank line) present, 12 files formatted, CI green.
One note: 3 files remain gofmt-dirty after this PR - config_manager/config_schema.go, merchant/lightning_state_test.go, merchant/quotes_wireformat_test.go (verified on this PR's tree with gofmt -l). They arrived in the merge wave after this branch was cut. Our orphaned rebuild 9a42098 covered all 14; happy to send a tiny follow-up PR finishing the remaining 3 once #353 (which also touches config_schema.go) and this land - say the word.
Amperstrand
left a comment
Amperstrand
left a comment
There was a problem hiding this comment.
Reviewed — pure gofmt across 16 files, no semantic changes; CI green. Note for merge order: tiny overlap with #353 in wireless_gateway_manager/scanner.go — merging #353 first keeps this trivially conflict-free (or vice-versa, one-line resolution). Approving.
(E2E cloud-lab run for this head is in flight; results will follow.)
|
E2E results: deployed head
Pure formatting PR — build + deploy + suites green, as expected. (Approve + merge at your discretion; #353 first keeps the scanner.go overlap trivial.) |
Pure formatting fixes. No code changes. gofmt -l . now returns empty.
…fore third-party with blank line separator)
2a35522 to
f2b5815
Compare
* chore: gofmt cleanup — 16 files Pure formatting fixes. No code changes. gofmt -l . now returns empty. * fix: cold review — correct import ordering in validator.go (stdlib before third-party with blank line separator) --------- Co-authored-by: Amperstrand <amperstrand@localhost> Co-authored-by: Felix <301398501+felixfelix-bot@users.noreply.github.com>
3 participants
Rebased version of #341. Conflicts resolved: gofmt whitespace in lightning.go and types.go, kept HEAD import names. 2 commits applied cleanly. Build verified.