Skip to content

Bring resources/DESIGN.md back under its 1000-line budget so main's Lint workflow passes #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kriszyp wants to merge 1 commit into from
Closed

Bring resources/DESIGN.md back under its 1000-line budget so main's Lint workflow passes #3634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions resources/DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,17 +341,7 @@ bit is persisted, so it cannot follow a renumbered rocksdb-js constant without a
`unitTests/resources/caching-rocks-database.test.js` ('marks a record whose version was reused…') pins
the layout against raw stored values.

A fill's puts carry no condition of their own: on LMDB the `LMDBTransaction` `ifVersion` block holds
the condition with the primary, index and audit puts in one native write transaction (a per-put
`ifVersion` cannot stop the index writes, and on the unversioned audit store it drops the write); on
RocksDB a conflict retries the commit handler. A write the source makes to the same key through its
context joins the fill's transaction, where neither check sees it. RocksDB reads the fill's
`existingEntry` through that transaction; LMDB's optimistic path reads the committed record, so on
LMDB the fill yields to any earlier same-key write not skipped (`followsAppliedWrite`), and a no-op
`update()` removed at validation leaves the per-key chain (`LMDBTransaction.removeWrite`). On LMDB an
invalidated record keeps its local time only while its audit entry exists to be replaced
(`recordUpdater`), since an appended entry is keyed by the last assigned time.
`unitTests/resources/sourceFillConditionalWrite.test.js` pins both engines.
A fill's puts carry no condition of their own: on LMDB the `LMDBTransaction` `ifVersion` block holds the condition with the primary, index and audit puts in one native write transaction (a per-put `ifVersion` cannot stop the index writes, and on the unversioned audit store it drops the write); on RocksDB a conflict retries the commit handler. A write the source makes to the same key through its context joins the fill's transaction, where neither check sees it. RocksDB reads the fill's `existingEntry` through that transaction; LMDB's optimistic path reads the committed record, so on LMDB the fill yields to any earlier same-key write not skipped (`followsAppliedWrite`), and a no-op `update()` removed at validation leaves the per-key chain (`LMDBTransaction.removeWrite`). On LMDB an invalidated record keeps its local time only while its audit entry exists to be replaced (`recordUpdater`), since an appended entry is keyed by the last assigned time. `unitTests/resources/sourceFillConditionalWrite.test.js` pins both engines.

## Blob orphan cleanup: pre-saved files outlive cancelled commits

Expand Down
Loading